Bug 1624330 - Removed a redundant CSS rule that caused snippet dismiss button to overlap content r=andreio
authoremcminn <emcminn@mozilla.com>
Tue, 24 Mar 2020 16:12:39 +0000
changeset 520232 a2059ce088fe9f218e37d49bdcbe4a62b9fc2abb
parent 520231 17611bdb12f105a1fa843f5165a32c41426c9888
child 520233 326a0419dcee4a2a4021f6bd94346b4b7d699119
push id37246
push useropoprus@mozilla.com
push dateWed, 25 Mar 2020 03:40:33 +0000
treeherdermozilla-central@14b59d4adc95 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersandreio
bugs1624330
milestone76.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1624330 - Removed a redundant CSS rule that caused snippet dismiss button to overlap content r=andreio Differential Revision: https://phabricator.services.mozilla.com/D67916
browser/components/newtab/content-src/asrouter/components/SnippetBase/_SnippetBase.scss
browser/components/newtab/css/activity-stream-linux.css
browser/components/newtab/css/activity-stream-mac.css
browser/components/newtab/css/activity-stream-windows.css
--- a/browser/components/newtab/content-src/asrouter/components/SnippetBase/_SnippetBase.scss
+++ b/browser/components/newtab/content-src/asrouter/components/SnippetBase/_SnippetBase.scss
@@ -61,20 +61,16 @@
     width: 16px;
     background-image: url('resource://activity-stream/data/content/assets/glyph-dismiss-16.svg');
     -moz-context-properties: fill;
     fill: var(--newtab-icon-primary-color);
     opacity: 0.5;
     margin-top: -8px;
     padding: 0;
     cursor: pointer;
-
-    @media (min-width: 766px) {
-      inset-inline-end: 24px;
-    }
   }
 
   &:hover .blockButton {
     display: block;
   }
 
   .icon {
     height: 42px;
--- a/browser/components/newtab/css/activity-stream-linux.css
+++ b/browser/components/newtab/css/activity-stream-linux.css
@@ -3324,19 +3324,16 @@ main {
     width: 16px;
     background-image: url("resource://activity-stream/data/content/assets/glyph-dismiss-16.svg");
     -moz-context-properties: fill;
     fill: var(--newtab-icon-primary-color);
     opacity: 0.5;
     margin-top: -8px;
     padding: 0;
     cursor: pointer; }
-    @media (min-width: 766px) {
-      .SnippetBaseContainer .blockButton {
-        inset-inline-end: 24px; } }
   .SnippetBaseContainer:hover .blockButton {
     display: block; }
   .SnippetBaseContainer .icon {
     height: 42px;
     width: 42px;
     margin-inline-end: 12px;
     flex-shrink: 0; }
 
--- a/browser/components/newtab/css/activity-stream-mac.css
+++ b/browser/components/newtab/css/activity-stream-mac.css
@@ -3327,19 +3327,16 @@ main {
     width: 16px;
     background-image: url("resource://activity-stream/data/content/assets/glyph-dismiss-16.svg");
     -moz-context-properties: fill;
     fill: var(--newtab-icon-primary-color);
     opacity: 0.5;
     margin-top: -8px;
     padding: 0;
     cursor: pointer; }
-    @media (min-width: 766px) {
-      .SnippetBaseContainer .blockButton {
-        inset-inline-end: 24px; } }
   .SnippetBaseContainer:hover .blockButton {
     display: block; }
   .SnippetBaseContainer .icon {
     height: 42px;
     width: 42px;
     margin-inline-end: 12px;
     flex-shrink: 0; }
 
--- a/browser/components/newtab/css/activity-stream-windows.css
+++ b/browser/components/newtab/css/activity-stream-windows.css
@@ -3324,19 +3324,16 @@ main {
     width: 16px;
     background-image: url("resource://activity-stream/data/content/assets/glyph-dismiss-16.svg");
     -moz-context-properties: fill;
     fill: var(--newtab-icon-primary-color);
     opacity: 0.5;
     margin-top: -8px;
     padding: 0;
     cursor: pointer; }
-    @media (min-width: 766px) {
-      .SnippetBaseContainer .blockButton {
-        inset-inline-end: 24px; } }
   .SnippetBaseContainer:hover .blockButton {
     display: block; }
   .SnippetBaseContainer .icon {
     height: 42px;
     width: 42px;
     margin-inline-end: 12px;
     flex-shrink: 0; }