Bug 1423253 - Improve MediaPipeline logging and fix formatting. r=dminor
authorAndreas Pehrson <apehrson@mozilla.com>
Fri, 22 Mar 2019 11:45:21 +0000
changeset 465660 9f3a6410605ac3a8eae9859d24c609e72010f428
parent 465659 9019e6f0a6c3a52b9215eea8a5f499b4290c8707
child 465661 7153764aded8aaede17ca3a15551a4e69a1da8ff
push id35744
push userapavel@mozilla.com
push dateFri, 22 Mar 2019 16:44:08 +0000
treeherdermozilla-central@e66a2b59914d [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersdminor
bugs1423253
milestone68.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1423253 - Improve MediaPipeline logging and fix formatting. r=dminor Differential Revision: https://phabricator.services.mozilla.com/D22929
dom/media/VideoFrameConverter.h
--- a/dom/media/VideoFrameConverter.h
+++ b/dom/media/VideoFrameConverter.h
@@ -256,17 +256,17 @@ class VideoFrameConverter {
         MOZ_DIAGNOSTIC_ASSERT(false,
                               "Buffers not leaving scope except for "
                               "reconfig, should never leak");
         MOZ_LOG(gVideoFrameConverterLog, LogLevel::Warning,
                 ("Creating a buffer for a black video frame failed"));
         return;
       }
 
-      MOZ_LOG(gVideoFrameConverterLog, LogLevel::Debug,
+      MOZ_LOG(gVideoFrameConverterLog, LogLevel::Verbose,
               ("Sending a black video frame"));
       webrtc::I420Buffer::SetBlack(buffer);
 
       webrtc::VideoFrame frame(buffer, 0, // not setting rtp timestamp
                                now, webrtc::kVideoRotation_0);
       VideoFrameConverted(frame);
       return;
     }
@@ -284,31 +284,31 @@ class VideoFrameConverter {
                 aImage->GetSize().width, aImage->GetSize().height,
                 data->mYChannel, data->mYStride, data->mCbChannel,
                 data->mCbCrStride, data->mCrChannel, data->mCbCrStride,
                 rtc::KeepRefUntilDone(image)));
 
         webrtc::VideoFrame i420_frame(video_frame_buffer,
                                       0, // not setting rtp timestamp
                                       now, webrtc::kVideoRotation_0);
-        MOZ_LOG(gVideoFrameConverterLog, LogLevel::Debug,
+        MOZ_LOG(gVideoFrameConverterLog, LogLevel::Verbose,
                 ("Sending an I420 video frame"));
         VideoFrameConverted(i420_frame);
         return;
       }
     }
 
     rtc::scoped_refptr<webrtc::I420Buffer> buffer =
         mBufferPool.CreateBuffer(aSize.width, aSize.height);
     if (!buffer) {
       MOZ_DIAGNOSTIC_ASSERT(false,
                             "Buffers not leaving scope except for "
                             "reconfig, should never leak");
       MOZ_LOG(gVideoFrameConverterLog, LogLevel::Warning,
-              ("Creating a buffer for a black video frame failed"));
+              ("Creating a buffer failed"));
       return;
     }
 
     nsresult rv =
         ConvertToI420(aImage, buffer->MutableDataY(), buffer->StrideY(),
                       buffer->MutableDataU(), buffer->StrideU(),
                       buffer->MutableDataV(), buffer->StrideV());