Bug 607002 - Classes forward-declared as structs in IPDL-generated code cause MSVC warnings. Forward-declare them as classes. r=cjones
authorBenjamin Smedberg <benjamin@smedbergs.us>
Wed, 27 Oct 2010 09:17:33 -0400
changeset 57217 9f1f861a9ff742ace1c25ec97c273eeaa5e326ab
parent 57216 c6a351a89dde8ee22010da6be19da3f9177bdb01
child 57218 5d416c488505e30c1d1c2446e4e9cadca4b0e444
push id16846
push userbsmedberg@mozilla.com
push dateWed, 10 Nov 2010 15:29:47 +0000
treeherdermozilla-central@bdbef533364f [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerscjones
bugs607002
milestone2.0b8pre
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 607002 - Classes forward-declared as structs in IPDL-generated code cause MSVC warnings. Forward-declare them as classes. r=cjones
ipc/ipdl/ipdl/lower.py
--- a/ipc/ipdl/ipdl/lower.py
+++ b/ipc/ipdl/ipdl/lower.py
@@ -1696,17 +1696,17 @@ def _generateCxxStruct(sd):
     # compute all the typedefs and forward decls we need to make
     gettypedeps = _ComputeTypeDeps(sd.decl.type)
     for f in sd.fields:
         f.ipdltype.accept(gettypedeps)
 
     usingTypedefs = gettypedeps.usingTypedefs
     forwarddeclstmts = gettypedeps.forwardDeclStmts
 
-    struct = Class(sd.name, struct=1, final=1)
+    struct = Class(sd.name, final=1)
     struct.addstmts([ Label.PRIVATE ]
                     + usingTypedefs
                     + [ Whitespace.NL, Label.PUBLIC ])
 
     constreftype = Type(sd.name, const=1, ref=1)
     initvar = ExprVar('Init')
     callinit = ExprCall(initvar)
     assignvar = ExprVar('Assign')