author | Kartikaya Gupta <kgupta@mozilla.com> |
Thu, 13 Aug 2020 09:45:26 +0000 | |
changeset 544510 | 9ef828c9bd891822d22c53a6af567023f0128568 |
parent 544509 | 4e0b6d7a8e48a9cf2c83ec41d5e433047b4f2da5 |
child 544511 | 06e4f8547d78187f934074b2b4ff4d4d4d12efd5 |
push id | 37696 |
push user | apavel@mozilla.com |
push date | Thu, 13 Aug 2020 15:46:18 +0000 |
treeherder | mozilla-central@06e4f8547d78 [default view] [failures only] |
perfherder | [talos] [build metrics] [platform microbench] (compared to previous push) |
reviewers | tnikkel |
bugs | 1648686 |
milestone | 81.0a1 |
first release with | nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
|
last release without | nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
|
--- a/widget/cocoa/nsChildView.mm +++ b/widget/cocoa/nsChildView.mm @@ -2671,18 +2671,18 @@ NSEvent* gLastDragMouseDownEvent = nil; NS_ENSURE_TRUE(rollupListener, false); nsCOMPtr<nsIWidget> rollupWidget = rollupListener->GetRollupWidget(); if (rollupWidget) { NSWindow* currentPopup = static_cast<NSWindow*>(rollupWidget->GetNativeData(NS_NATIVE_WINDOW)); if (!nsCocoaUtils::IsEventOverWindow(theEvent, currentPopup)) { // event is not over the rollup window, default is to roll up bool shouldRollup = true; - // check to see if scroll events should roll up the popup - if ([theEvent type] == NSScrollWheel) { + // check to see if scroll/zoom events should roll up the popup + if ([theEvent type] == NSScrollWheel || [theEvent type] == NSEventTypeMagnify) { shouldRollup = rollupListener->ShouldRollupOnMouseWheelEvent(); // consume scroll events that aren't over the popup // unless the popup is an arrow panel consumeEvent = rollupListener->ShouldConsumeOnMouseWheelEvent(); } // if we're dealing with menus, we probably have submenus and // we don't want to rollup if the click is in a parent menu of