Back out rev b89286a88588 (bug 1442344) for hitting the MOZ_CRASH on Android opt builds.
authorBoris Zbarsky <bzbarsky@mit.edu>
Fri, 02 Mar 2018 12:27:48 -0500
changeset 406277 9caf14e0b300424d05fe5dd5afa7b9d1c65a5416
parent 406276 5e2c4277fd0c947a2454b174f4e39b270057ebd0
child 406278 426b0a284cf478729ee90eee9c409b89e27bae47
push id33551
push userbzbarsky@mozilla.com
push dateFri, 02 Mar 2018 17:28:07 +0000
treeherdermozilla-central@9caf14e0b300 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
bugs1442344
milestone60.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Back out rev b89286a88588 (bug 1442344) for hitting the MOZ_CRASH on Android opt builds. MozReview-Commit-ID: F7zCmO5zDUq
dom/base/nsGlobalWindowInner.h
--- a/dom/base/nsGlobalWindowInner.h
+++ b/dom/base/nsGlobalWindowInner.h
@@ -274,17 +274,17 @@ public:
   void ReallyCloseWindow();
 
   // nsISupports
   NS_DECL_CYCLE_COLLECTING_ISUPPORTS
 
   // nsWrapperCache
   virtual JSObject *WrapObject(JSContext *cx, JS::Handle<JSObject*> aGivenProto) override
   {
-    MOZ_CRASH("We should never get here!");
+    return GetWrapper();
   }
 
   // nsIGlobalJSObjectHolder
   virtual JSObject* GetGlobalJSObject() override;
 
   // nsIScriptGlobalObject
   JSObject *FastGetGlobalJSObject() const
   {