Disable inefficient query warning (tracked in bug 482351)
authorShawn Wilsher <sdwilsh@shawnwilsher.com>
Fri, 20 Mar 2009 17:02:23 -0400
changeset 26426 9c5103a865e7b0b785fbbeaa4eb8e8803630eb55
parent 26425 8f59f15f01a0c416a155c4c277e1733897ec7cd5
child 26427 f45743a633feb8420f669d1073c9b6b68c0a23eb
push id6062
push usersdwilsh@shawnwilsher.com
push dateFri, 20 Mar 2009 21:03:01 +0000
treeherdermozilla-central@f45743a633fe [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
bugs482351
milestone1.9.2a1pre
Disable inefficient query warning (tracked in bug 482351) rs=dietrich
toolkit/components/places/src/nsNavHistory.cpp
--- a/toolkit/components/places/src/nsNavHistory.cpp
+++ b/toolkit/components/places/src/nsNavHistory.cpp
@@ -7673,16 +7673,17 @@ nsNavHistory::GetDBInvalidFrecencies()
   // We get two sets of places that are 1) most visited and 2) random so that
   // we don't get stuck recalculating frecencies that end up being -1 every
   // time
   // Since we don't need real random results and ORDER BY RANDOM() is slow
   // we will jump at a random rowid in the table and we will get random results
   // only from moz_places since temp will be synched there sometimes.  
   // Notice that frecency is invalidated as frecency = -visit_count
   nsresult rv = mDBConn->CreateStatement(NS_LITERAL_CSTRING(
+      "/* do not warn (bug 482351) */ "
       "SELECT * FROM ( "
         "SELECT id, visit_count, hidden, typed, frecency, url "
         "FROM ( "
           "SELECT * FROM moz_places_temp "
           "WHERE frecency < 0 "
           "UNION ALL "
           "SELECT * FROM ( "
             "SELECT * FROM moz_places "