Bug 1109160: Report Gecko version in SDP. r=abr
authorByron Campen [:bwc] <docfaraday@gmail.com>
Wed, 10 Dec 2014 15:17:55 -0800 (2014-12-10)
changeset 219556 9c345f9803f1d14ef578ac73e7b6e24d3e0411e8
parent 219555 8628a94a64445c1f66b349a8bbd391596e633adc
child 219557 c306922867aad00cde8dbdd687e81081c10ba8c0
push id27967
push userryanvm@gmail.com
push dateMon, 15 Dec 2014 18:52:54 +0000 (2014-12-15)
treeherdermozilla-central@5d6e0d038f95 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersabr
bugs1109160
milestone37.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1109160: Report Gecko version in SDP. r=abr
media/webrtc/signaling/src/jsep/JsepSessionImpl.cpp
--- a/media/webrtc/signaling/src/jsep/JsepSessionImpl.cpp
+++ b/media/webrtc/signaling/src/jsep/JsepSessionImpl.cpp
@@ -1394,17 +1394,21 @@ JsepSessionImpl::CreateGenericSDP(Unique
   //     version> field SHOULD be zero.  The value of the <nettype>
   //     <addrtype> <unicast-address> tuple SHOULD be set to a non-
   //     meaningful address, such as IN IP4 0.0.0.0, to prevent leaking the
   //     local address in this field.  As mentioned in [RFC4566], the
   //     entire o= line needs to be unique, but selecting a random number
   //     for <sess-id> is sufficient to accomplish this.
 
   auto origin =
-      SdpOrigin("-", mSessionId, mSessionVersion, sdp::kIPv4, "0.0.0.0");
+      SdpOrigin("mozilla...THIS_IS_SDPARTA-" MOZ_APP_UA_VERSION,
+                mSessionId,
+                mSessionVersion,
+                sdp::kIPv4,
+                "0.0.0.0");
 
   UniquePtr<Sdp> sdp = MakeUnique<SipccSdp>(origin);
 
   if (mDtlsFingerprints.empty()) {
     JSEP_SET_ERROR("Missing DTLS fingerprint");
     return NS_ERROR_FAILURE;
   }