Bug 888034: No rounded corners on dominant colored backgrounds on BookmarkThumbnailView. [r=margaret]
authorSriram Ramasubramanian <sriram@mozilla.com>
Fri, 28 Jun 2013 11:08:34 -0700
changeset 143367 9c2d41078e3bb1d0399f4b08245f9b995de95671
parent 143366 226fa98cb589d1eef54d71e8113b7aec82da88ea
child 143368 2f186c2d4a411cf3a015d95379bff91f741be8f6
push id25130
push userlrocha@mozilla.com
push dateWed, 21 Aug 2013 09:41:27 +0000
treeherdermozilla-central@b2486721572e [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmargaret
bugs888034
milestone24.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 888034: No rounded corners on dominant colored backgrounds on BookmarkThumbnailView. [r=margaret]
mobile/android/base/Makefile.in
mobile/android/base/home/BookmarkThumbnailView.java
mobile/android/base/resources/drawable/bookmark_thumbnail_bg.xml
--- a/mobile/android/base/Makefile.in
+++ b/mobile/android/base/Makefile.in
@@ -1013,16 +1013,17 @@ RES_LAYOUT += res/layout/crash_reporter.
 endif
 
 MOZ_ANDROID_DRAWABLES += \
   $(SYNC_RES_DRAWABLE)                                                          \
   mobile/android/base/resources/drawable/abouthome_logo.xml                     \
   mobile/android/base/resources/drawable/abouthome_promo_box.xml                \
   mobile/android/base/resources/drawable/action_bar_button.xml                  \
   mobile/android/base/resources/drawable/action_bar_button_inverse.xml          \
+  mobile/android/base/resources/drawable/bookmark_thumbnail_bg.xml              \
   mobile/android/base/resources/drawable/url_bar_bg.xml                         \
   mobile/android/base/resources/drawable/url_bar_bg_shadow_repeat.xml           \
   mobile/android/base/resources/drawable/url_bar_entry.xml                      \
   mobile/android/base/resources/drawable/url_bar_nav_button.xml                 \
   mobile/android/base/resources/drawable/url_bar_right_edge.xml                 \
   mobile/android/base/resources/drawable/bookmark_folder.xml                    \
   mobile/android/base/resources/drawable/favicon_bg.xml                         \
   mobile/android/base/resources/drawable/handle_end_level.xml                   \
--- a/mobile/android/base/home/BookmarkThumbnailView.java
+++ b/mobile/android/base/home/BookmarkThumbnailView.java
@@ -93,14 +93,14 @@ public class BookmarkThumbnailView exten
     /**
      * Sets the background to a Drawable by applying the specified color as a filter.
      *
      * @param color the color filter to apply over the drawable.
      */
     @Override
     public void setBackgroundColor(int color) {
         int colorFilter = color == 0 ? DEFAULT_COLOR : color & COLOR_FILTER;
-        Drawable drawable = getResources().getDrawable(R.drawable.favicon_bg);
+        Drawable drawable = getResources().getDrawable(R.drawable.bookmark_thumbnail_bg);
         drawable.setColorFilter(colorFilter, Mode.SRC_ATOP);
         setBackgroundDrawable(drawable);
         mShowBorder = false;
     }
 }
new file mode 100644
--- /dev/null
+++ b/mobile/android/base/resources/drawable/bookmark_thumbnail_bg.xml
@@ -0,0 +1,12 @@
+<?xml version="1.0" encoding="utf-8"?>
+<!-- This Source Code Form is subject to the terms of the Mozilla Public
+   - License, v. 2.0. If a copy of the MPL was not distributed with this
+   - file, You can obtain one at http://mozilla.org/MPL/2.0/. -->
+
+<shape xmlns:android="http://schemas.android.com/apk/res/android"
+       android:shape="rectangle">
+     <size android:height="2dp"
+           android:width="2dp"/>
+     <solid android:color="#FFFFFFFF"/>
+     <stroke android:width="1dp" android:color="#FFDDDDDD"/>
+</shape>