Bug 1521092 - ARM64: pop(FloatRegister) use ARMFPRegister instead of the register code. r=sstangl
authorNicolas B. Pierron <nicolas.b.pierron@nbp.name>
Wed, 23 Jan 2019 19:35:00 +0100
changeset 455389 9c28047982f2ef9cae4e87301b8148230af7e17f
parent 455388 35d94075e745d86bea017e573d11388b810f0ee8
child 455390 569e83cc7e4c3a6fa343f0db093d82f4b5add3d0
push id35436
push userncsoregi@mozilla.com
push dateFri, 25 Jan 2019 17:00:32 +0000
treeherdermozilla-central@90fb8bea5ef5 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerssstangl
bugs1521092
milestone66.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1521092 - ARM64: pop(FloatRegister) use ARMFPRegister instead of the register code. r=sstangl
js/src/jit/arm64/MacroAssembler-arm64.h
--- a/js/src/jit/arm64/MacroAssembler-arm64.h
+++ b/js/src/jit/arm64/MacroAssembler-arm64.h
@@ -214,17 +214,17 @@ class MacroAssemblerCompat : public vixl
   }
   void pop(ARMFPRegister r0, ARMFPRegister r1, ARMFPRegister r2,
            ARMFPRegister r3) {
     vixl::MacroAssembler::Pop(r0, r1, r2, r3);
   }
 
   void pop(const ValueOperand& v) { pop(v.valueReg()); }
   void pop(const FloatRegister& f) {
-    vixl::MacroAssembler::Pop(ARMRegister(f.code(), 64));
+    vixl::MacroAssembler::Pop(ARMFPRegister(f, 64));
   }
 
   void implicitPop(uint32_t args) {
     MOZ_ASSERT(args % sizeof(intptr_t) == 0);
     adjustFrame(0 - args);
   }
   void Pop(ARMRegister r) {
     vixl::MacroAssembler::Pop(r);