author | Josh Matthews <josh@joshmatthews.net> |
Wed, 28 Nov 2012 11:24:03 -0500 | |
changeset 114372 | 9c0bd1afbf063a651899ea2275442f8bfe83986d |
parent 114371 | 7c45205a61a0d6681f5302d4670bc74d9bed6636 |
child 114373 | 2d3251f224f748bb95a587f3af07159ca2a09435 |
push id | 23917 |
push user | emorley@mozilla.com |
push date | Thu, 29 Nov 2012 14:20:29 +0000 |
treeherder | mozilla-central@c72d38e7a212 [default view] [failures only] |
perfherder | [talos] [build metrics] [platform microbench] (compared to previous push) |
reviewers | bz, bsmith |
bugs | 812794 |
milestone | 20.0a1 |
first release with | nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
|
last release without | nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
|
--- a/docshell/base/nsDocShell.cpp +++ b/docshell/base/nsDocShell.cpp @@ -109,17 +109,16 @@ #include "nsIFileURL.h" #include "nsIHistoryEntry.h" #include "nsISHistoryListener.h" #include "nsIWindowWatcher.h" #include "nsIPromptFactory.h" #include "nsIObserver.h" #include "nsINestedURI.h" #include "nsITransportSecurityInfo.h" -#include "nsISSLSocketControl.h" #include "nsINSSErrorsService.h" #include "nsIApplicationCache.h" #include "nsIApplicationCacheChannel.h" #include "nsIApplicationCacheContainer.h" #include "nsIPermissionManager.h" #include "nsStreamUtils.h" #include "nsIController.h" #include "nsPICommandUpdater.h" @@ -4170,21 +4169,18 @@ nsDocShell::DisplayLoadError(nsresult aE if (errorClass == nsINSSErrorsService::ERROR_CLASS_BAD_CERT) { error.AssignLiteral("nssBadCert"); // if this is a Strict-Transport-Security host and the cert // is bad, don't allow overrides (STS Spec section 7.3). nsCOMPtr<nsIStrictTransportSecurityService> stss = do_GetService(NS_STSSERVICE_CONTRACTID, &rv); NS_ENSURE_SUCCESS(rv, rv); - uint32_t flags = 0; - nsCOMPtr<nsISSLSocketControl> socketControl = do_QueryInterface(tsi); - if (socketControl) { - socketControl->GetProviderFlags(&flags); - } + uint32_t flags = + mInPrivateBrowsing ? nsISocketProvider::NO_PERMANENT_STORAGE : 0; bool isStsHost = false; rv = stss->IsStsURI(aURI, flags, &isStsHost); NS_ENSURE_SUCCESS(rv, rv); uint32_t bucketId; if (isStsHost) { cssClass.AssignLiteral("badStsCert");
--- a/security/manager/ssl/src/TransportSecurityInfo.h +++ b/security/manager/ssl/src/TransportSecurityInfo.h @@ -12,17 +12,16 @@ #include "mozilla/RefPtr.h" #include "nsIInterfaceRequestor.h" #include "nsITransportSecurityInfo.h" #include "nsSSLStatus.h" #include "nsISSLStatusProvider.h" #include "nsIAssociatedContentSecurity.h" #include "nsNSSShutDown.h" #include "nsDataHashtable.h" -#include "nsISocketTransport.h" namespace mozilla { namespace psm { enum SSLErrorMessageType { OverridableCertErrorMessage = 1, // for *overridable* certificate errors PlainErrorMessage = 2 // all other errors (or "no error") };
--- a/security/manager/ssl/src/nsNSSIOLayer.cpp +++ b/security/manager/ssl/src/nsNSSIOLayer.cpp @@ -2340,17 +2340,17 @@ nsSSLIOLayerImportFD(PRFileDesc *fd, return nullptr; } SSL_SetPKCS11PinArg(sslSock, (nsIInterfaceRequestor*)infoObject); SSL_HandshakeCallback(sslSock, HandshakeCallback, infoObject); // Disable this hook if we connect anonymously. See bug 466080. uint32_t flags = 0; infoObject->GetProviderFlags(&flags); - if (flags & nsISocketTransport::ANONYMOUS_CONNECT) { + if (flags & nsISocketProvider::ANONYMOUS_CONNECT) { SSL_GetClientAuthDataHook(sslSock, nullptr, infoObject); } else { SSL_GetClientAuthDataHook(sslSock, (SSLGetClientAuthData)nsNSS_SSLGetClientAuthData, infoObject); } if (SECSuccess != SSL_AuthCertificateHook(sslSock, AuthCertificateHook, infoObject)) {
--- a/security/manager/ssl/src/nsNSSIOLayer.h +++ b/security/manager/ssl/src/nsNSSIOLayer.h @@ -8,17 +8,16 @@ #define _NSNSSIOLAYER_H #include "TransportSecurityInfo.h" #include "nsISSLSocketControl.h" #include "nsIClientAuthDialogs.h" #include "nsNSSCertificate.h" #include "nsDataHashtable.h" #include "nsTHashtable.h" -#include "nsISocketTransport.h" #include "mozilla/TimeStamp.h" class nsNSSSocketInfo : public mozilla::psm::TransportSecurityInfo, public nsISSLSocketControl, public nsIClientAuthUserDecision { public: nsNSSSocketInfo(uint32_t providerFlags);