Bug 1400390 - Fix wrong colspan of media section in about:support; r=Felipe
authorChun-Min Chang <chun.m.chang@gmail.com>
Mon, 18 Sep 2017 11:44:23 +0800
changeset 382193 9a57f4e9c624b11fcd2d377fdfa0a75f9ae6aeb3
parent 382192 566ab2ce53295d5ae3b6e427ccced3083b7ec5e3
child 382194 c81fde3ad750d822ceef730fb70ef10bd58ede3b
push id32551
push userkwierso@gmail.com
push dateThu, 21 Sep 2017 23:29:53 +0000
treeherdermozilla-central@d6d6fd889f7b [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersFelipe
bugs1400390
milestone57.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1400390 - Fix wrong colspan of media section in about:support; r=Felipe MozReview-Commit-ID: AUgYMEKMKvf
toolkit/content/aboutSupport.js
toolkit/content/aboutSupport.xhtml
--- a/toolkit/content/aboutSupport.js
+++ b/toolkit/content/aboutSupport.js
@@ -601,16 +601,17 @@ var snapshotFormatters = {
   media: function media(data) {
     let strings = stringBundle();
 
     function insertBasicInfo(key, value) {
       function createRow(key, value) {
         let th = $.new("th", strings.GetStringFromName(key), "column");
         let td = $.new("td", value);
         td.style["white-space"] = "pre-wrap";
+        td.colSpan = 8;
         return $.new("tr", [th, td]);
       }
       $.append($("media-info-tbody"), [createRow(key, value)]);
     }
 
     function createDeviceInfoRow(device) {
       let deviceInfo = Ci.nsIAudioDeviceInfo;
 
--- a/toolkit/content/aboutSupport.xhtml
+++ b/toolkit/content/aboutSupport.xhtml
@@ -447,17 +447,17 @@
         &aboutSupport.mediaTitle;
       </h2>
       <table>
         <tbody id="media-info-tbody">
         </tbody>
 
         <tbody id="media-output-devices-tbody">
           <tr>
-            <th colspan="10" class="title-column">
+            <th colspan="9" class="title-column">
               &aboutSupport.mediaOutputDevicesTitle;
             </th>
           </tr>
           <tr>
             <th>
               &aboutSupport.mediaDeviceName;
             </th>
             <th>
@@ -484,17 +484,17 @@
             <th>
               &aboutSupport.mediaDeviceLatency;
             </th>
           </tr>
         </tbody>
 
         <tbody id="media-input-devices-tbody">
           <tr>
-            <th colspan="10" class="title-column">
+            <th colspan="9" class="title-column">
               &aboutSupport.mediaInputDevicesTitle;
             </th>
           </tr>
           <tr>
             <th>
               &aboutSupport.mediaDeviceName;
             </th>
             <th>