Bug 1455165 - Filter external apps out if needed. r=mcomella
authorIgor Oliveira <igt0@torproject.org>
Wed, 18 Apr 2018 17:16:00 +0300 (2018-04-18)
changeset 415507 9a092f00fdd698ea9b3f705dcea9e32b9979fb28
parent 415506 cbae9dd052934b6292f8e8675eb6cf7cde78333d
child 415508 44e4fec63d98c64f71591f93d6ee13c00e75ad64
push id33896
push userrgurzau@mozilla.com
push dateWed, 25 Apr 2018 09:36:32 +0000 (2018-04-25)
treeherdermozilla-central@a83a4ef50f6c [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmcomella
bugs1455165
milestone61.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1455165 - Filter external apps out if needed. r=mcomella
mobile/android/chrome/content/browser.js
--- a/mobile/android/chrome/content/browser.js
+++ b/mobile/android/chrome/content/browser.js
@@ -6248,16 +6248,20 @@ var ExternalApps = {
 
       return apps.length == 1 ? Strings.browser.formatStringFromName("helperapps.openWithApp2", [apps[0].name], 1) :
                                 Strings.browser.GetStringFromName("helperapps.openWithList2");
     }, this.filter, this.openExternal);
   },
 
   filter: {
     matches: function(aElement) {
+      if (!Services.prefs.getBoolPref("network.protocol-handler.external-default")) {
+        return false;
+      }
+
       let uri = ExternalApps._getMediaLink(aElement);
       let apps = [];
       if (uri) {
         apps = HelperApps.getAppsForUri(uri);
       }
       return apps.length > 0;
     }
   },