Bug 1448306: Allow BinScope to run on clang-cl builds. r=froydnj
authorDavid Major <dmajor@mozilla.com>
Thu, 29 Mar 2018 15:11:41 -0400
changeset 410740 991e17b4fafa43bde62f1724ae7af2eb598b9465
parent 410739 2d22f513669f372690e695d172fe4b1d89892cb8
child 410741 fd3cb62ee635249e23e445749b2f60582b44f7db
push id33736
push usershindli@mozilla.com
push dateFri, 30 Mar 2018 09:56:41 +0000
treeherdermozilla-central@b7fa9d95150e [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersfroydnj
bugs1448306
milestone61.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1448306: Allow BinScope to run on clang-cl builds. r=froydnj
build/win32/Makefile.in
--- a/build/win32/Makefile.in
+++ b/build/win32/Makefile.in
@@ -1,14 +1,11 @@
 # This Source Code Form is subject to the terms of the Mozilla Public
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
 
 include $(topsrcdir)/config/rules.mk
 
 # run the binscope tool to make sure the binary and all libraries
 # are using all available Windows OS-level security mechanisms
-# Don't do this in clang-cl since it doesn't support debug information yet.
-ifndef CLANG_CL
 check::
 	$(PYTHON) $(srcdir)/autobinscope.py $(DIST)/bin/$(MOZ_APP_NAME)$(BIN_SUFFIX) $(DIST)/crashreporter-symbols/
 	$(PYTHON) $(srcdir)/autobinscope.py $(DIST)/bin/plugin-container.exe $(DIST)/crashreporter-symbols/
-endif