Bug 1475382 - Turn off async content process launching, pending better error handling. r=spohl
authorJed Davis <jld@mozilla.com>
Fri, 13 Jul 2018 15:20:25 -0600
changeset 427205 99011a1e3da55e8f58054e6646cd10fab9e590b9
parent 427204 7c10f1db88f01d23aa1a9406f6a7d9b295feaa42
child 427206 5351f1299717c5a09cc39ee149c1b1a53fac04b8
push id34296
push userrgurzau@mozilla.com
push dateThu, 19 Jul 2018 09:52:36 +0000
treeherdermozilla-central@25c83a66f294 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersspohl
bugs1475382
milestone63.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1475382 - Turn off async content process launching, pending better error handling. r=spohl At the moment this isn't actually async because we immediately require the pid and block on launch anyway. It also crashes the entire browser on otherwise recoverable launch errors, because code that wants the pid isn't set up to handle that operation failing. MozReview-Commit-ID: 5favGu34QCv
dom/ipc/moz.build
ipc/glue/moz.build
--- a/dom/ipc/moz.build
+++ b/dom/ipc/moz.build
@@ -179,18 +179,15 @@ MOCHITEST_CHROME_MANIFESTS += ['tests/ch
 MOCHITEST_MANIFESTS += ['tests/mochitest.ini']
 XPCSHELL_TESTS_MANIFESTS += ['tests/xpcshell.ini']
 
 CXXFLAGS += CONFIG['TK_CFLAGS']
 
 if CONFIG['CC_TYPE'] in ('clang', 'gcc'):
     CXXFLAGS += ['-Wno-error=shadow']
 
-if CONFIG['NIGHTLY_BUILD']:
-    DEFINES['ASYNC_CONTENTPROC_LAUNCH'] = True
-
 if CONFIG['FUZZING'] and CONFIG['FUZZING_INTERFACES']:
     TEST_DIRS += [
         'fuzztest'
     ]
 
 # Add libFuzzer configuration directives
 include('/tools/fuzzing/libfuzzer-config.mozbuild')
--- a/ipc/glue/moz.build
+++ b/ipc/glue/moz.build
@@ -232,13 +232,10 @@ if CONFIG['MOZ_SANDBOX'] and CONFIG['OS_
         '/security/sandbox/chromium',
         '/security/sandbox/chromium-shim',
         '/security/sandbox/win/src/sandboxbroker',
     ]
 
 if CONFIG['CC_TYPE'] in ('clang', 'gcc'):
     CXXFLAGS += ['-Wno-shadow']
 
-if CONFIG['NIGHTLY_BUILD']:
-    DEFINES['ASYNC_CONTENTPROC_LAUNCH'] = True
-
 # Add libFuzzer configuration directives
 include('/tools/fuzzing/libfuzzer-config.mozbuild')