Bug 1569877 - Consider textarea as a replaced element; r=miker
authorPatrick Brosset <pbrosset@mozilla.com>
Tue, 30 Jul 2019 12:56:03 +0000
changeset 485315 99003d5e05c88cdefa1e8b7b0c99051c78fc6d01
parent 485314 23956b86e0b6b7e704bb0a022a824b835c7a6ede
child 485316 c3e3ed30085e42bc6b9c0138258a9435137fd6b2
push id36364
push userdvarga@mozilla.com
push dateTue, 30 Jul 2019 21:50:30 +0000
treeherdermozilla-central@e259d43073bc [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmiker
bugs1569877
milestone70.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1569877 - Consider textarea as a replaced element; r=miker Differential Revision: https://phabricator.services.mozilla.com/D39866
devtools/server/actors/utils/inactive-property-helper.js
devtools/server/tests/mochitest/inactive-property-helper/max-min-width-height.js
--- a/devtools/server/actors/utils/inactive-property-helper.js
+++ b/devtools/server/actors/utils/inactive-property-helper.js
@@ -481,16 +481,17 @@ class InactivePropertyHelper {
         "math",
         "object",
         "picture",
         // Select is a replaced element if it has `size<=1` or no size specified, but
         // unconditionally treating it as replaced is enough for our purpose here, and
         // avoids extra complexity that will likely not be necessary in most cases.
         "select",
         "svg",
+        "textarea",
         "video",
       ])
     ) {
       return true;
     }
 
     // img tags are replaced elements only when the image has finished loading.
     if (this.nodeName === "img" && this.node.complete) {
--- a/devtools/server/tests/mochitest/inactive-property-helper/max-min-width-height.js
+++ b/devtools/server/tests/mochitest/inactive-property-helper/max-min-width-height.js
@@ -106,16 +106,23 @@ export default [
   {
     info: "width is active on an inline select element",
     property: "width",
     tagName: "select",
     rules: ["select { display: inline; width: 500px; }"],
     isActive: true,
   },
   {
+    info: "width is active on a textarea element",
+    property: "width",
+    tagName: "textarea",
+    rules: ["textarea { width: 500px; }"],
+    isActive: true,
+  },
+  {
     info: "min-width is active on a replaced inline element",
     property: "min-width",
     tagName: "img",
     rules: ["img { min-width: 500px; }"],
     isActive: true,
   },
   {
     info: "max-width is active on a replaced inline element",
@@ -225,16 +232,23 @@ export default [
   {
     info: "height is active on an inline select element",
     property: "height",
     tagName: "select",
     rules: ["select { display: inline; height: 500px; }"],
     isActive: true,
   },
   {
+    info: "height is active on a textarea element",
+    property: "height",
+    tagName: "textarea",
+    rules: ["textarea { height: 500px; }"],
+    isActive: true,
+  },
+  {
     info: "min-height is active on a replaced inline element",
     property: "min-height",
     tagName: "img",
     rules: ["img { min-height: 500px; }"],
     isActive: true,
   },
   {
     info: "max-height is active on a replaced inline element",