Bug 1619837 - Extend `fix-stacks` dependencies. r=glandium
authorNicholas Nethercote <nnethercote@mozilla.com>
Tue, 10 Mar 2020 06:27:56 +0000
changeset 517756 973cf06031df83a44271206f3f7750abf32aa3cb
parent 517755 f0e9e96d39ad266131071b86e48a09e38f45be24
child 517757 7b6356b842a5abdbc899f2cb7add7930bde7bb8b
push id37201
push usercsabou@mozilla.com
push dateTue, 10 Mar 2020 17:04:55 +0000
treeherdermozilla-central@aca7870ec936 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersglandium
bugs1619837
milestone76.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1619837 - Extend `fix-stacks` dependencies. r=glandium First, with `fix_stacks.py` now being used on most test suites, those test suites need a dependency on `fix-stacks`. Second, for those few configurations that don't run xpcshell tests, we need a `fix-stacks` dependency in the build job. This is because xpcshell self tests run during the build job, but the existing xpcshell test dependency doesn't cover that case. Differential Revision: https://phabricator.services.mozilla.com/D65943
taskcluster/ci/build/linux.yml
taskcluster/ci/build/windows.yml
taskcluster/ci/test/kind.yml
--- a/taskcluster/ci/build/linux.yml
+++ b/taskcluster/ci/build/linux.yml
@@ -1028,16 +1028,20 @@ linux64-asan/debug:
             - linux64-rust
             - linux64-rust-size
             - linux64-cbindgen
             - linux64-sccache
             - linux64-nasm
             - linux64-node
             - linux64-lucetc
             - wasi-sysroot
+            # `fix-stacks` is needed because xpcshell self tests run as part of
+            # the build step. Once bug 1614626 moves them to the xpcshell task,
+            # this dependency can be removed.
+            - linux64-fix-stacks
 
 linux64-shippable/opt:
     description: "Linux64 Shippable"
     use-pgo: true
     attributes:
         shippable: true
         enable-full-crashsymbols: true
     shipping-phase: build
--- a/taskcluster/ci/build/windows.yml
+++ b/taskcluster/ci/build/windows.yml
@@ -551,16 +551,20 @@ win64-noopt/debug:
         toolchain:
             - win64-clang-cl
             - win64-rust
             - win64-rust-size
             - win64-cbindgen
             - win64-sccache
             - win64-nasm
             - win64-node
+            # `fix-stacks` is needed because xpcshell self tests run as part of
+            # the build step. Once bug 1614626 moves them to the xpcshell task,
+            # this dependency can be removed.
+            - win32-fix-stacks
 
 win32-noopt/debug:
     description: "Win32 No-optimize Debug"
     index:
         product: firefox
         job-name: win32-noopt-debug
     treeherder:
         platform: windows2012-32-noopt/debug
@@ -586,16 +590,20 @@ win32-noopt/debug:
         toolchain:
             - win64-clang-cl
             - win64-rust
             - win64-rust-size
             - win64-cbindgen
             - win64-sccache
             - win64-nasm
             - win64-node
+            # `fix-stacks` is needed because xpcshell self tests run as part of
+            # the build step. Once bug 1614626 moves them to the xpcshell task,
+            # this dependency can be removed.
+            - win32-fix-stacks
 
 win32-rusttests/opt:
     description: "Win32 Rust Tests Opt"
     index:
         product: firefox
         job-name: win32-rusttests-opt
     treeherder:
         platform: windows2012-32/opt
@@ -815,16 +823,20 @@ win64-asan/debug:
         toolchain:
             - win64-clang-cl
             - win64-rust
             - win64-rust-size
             - win64-cbindgen
             - win64-sccache
             - win64-nasm
             - win64-node
+            # `fix-stacks` is needed because xpcshell self tests run as part of
+            # the build step. Once bug 1614626 moves them to the xpcshell task,
+            # this dependency can be removed.
+            - win32-fix-stacks
 
 win64-asan/opt:
     description: "Win64 Opt ASAN"
     index:
         product: firefox
         job-name: win64-asan-opt
     treeherder:
         platform: windows2012-64/asan
--- a/taskcluster/ci/test/kind.yml
+++ b/taskcluster/ci/test/kind.yml
@@ -55,12 +55,15 @@ job-defaults:
                     .*-devedition/.*: false
                     default: true
             default: false
     fetches:
         toolchain:
             by-test-platform:
                 win.*:
                     - win32-minidump-stackwalk
+                    - win32-fix-stacks
                 macosx.*:
                     - macosx64-minidump-stackwalk
+                    - macosx64-fix-stacks
                 default:
                     - linux64-minidump-stackwalk
+                    - linux64-fix-stacks