Bug 1397278 - Move the urlbar-go-button node to make its layout work more consistently with other urlbar-icons, and remove obsolete search-go-container padding. r=adw
authorDão Gottwald <dao@mozilla.com>
Tue, 12 Sep 2017 15:42:20 +0200
changeset 380422 97299b4db2983212c95e4994d3ed9d6c151499eb
parent 380421 0509b09c11fa0d9b72173404eecfcbe1752d89df
child 380423 1105de1e682006291c181271cbf8dac128b66aa9
push id32487
push userarchaeopteryx@coole-files.de
push dateWed, 13 Sep 2017 11:33:24 +0000
treeherdermozilla-central@1888ec2f277f [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersadw
bugs1397278
milestone57.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1397278 - Move the urlbar-go-button node to make its layout work more consistently with other urlbar-icons, and remove obsolete search-go-container padding. r=adw MozReview-Commit-ID: 5AHHxey9joo
browser/base/content/urlbarBindings.xml
browser/themes/windows/browser.css
--- a/browser/base/content/urlbarBindings.xml
+++ b/browser/base/content/urlbarBindings.xml
@@ -36,22 +36,22 @@ file, You can obtain one at http://mozil
                   class="textbox-input-box urlbar-input-box"
                   flex="1" xbl:inherits="tooltiptext=inputtooltiptext">
           <children/>
           <html:input anonid="input"
                       class="autocomplete-textbox urlbar-input textbox-input uri-element-right-align"
                       allowevents="true"
                       inputmode="url"
                       xbl:inherits="tooltiptext=inputtooltiptext,value,maxlength,disabled,size,readonly,placeholder,tabindex,accesskey,focused,textoverflow"/>
-          <xul:image anonid="urlbar-go-button"
-                     class="urlbar-go-button urlbar-icon"
-                     onclick="gURLBar.handleCommand(event);"
-                     tooltiptext="&goEndCap.tooltip;"
-                     xbl:inherits="pageproxystate,parentfocused=focused,usertyping"/>
         </xul:hbox>
+        <xul:image anonid="urlbar-go-button"
+                   class="urlbar-go-button urlbar-icon"
+                   onclick="gURLBar.handleCommand(event);"
+                   tooltiptext="&goEndCap.tooltip;"
+                   xbl:inherits="pageproxystate,parentfocused=focused,usertyping"/>
         <xul:dropmarker anonid="historydropmarker"
                         class="autocomplete-history-dropmarker urlbar-history-dropmarker urlbar-icon"
                         tooltiptext="&urlbar.openHistoryPopup.tooltip;"
                         allowevents="true"
                         xbl:inherits="open,enablehistory,parentfocused=focused,usertyping"/>
         <children includes="hbox"/>
       </xul:hbox>
       <xul:popupset anonid="popupset"
--- a/browser/themes/windows/browser.css
+++ b/browser/themes/windows/browser.css
@@ -540,20 +540,16 @@ html|*.urlbar-input:-moz-lwtheme::placeh
   }
 }
 
 #urlbar-zoom-button {
   -moz-appearance: none;
   color: inherit;
 }
 
-.search-go-container {
-  padding: 2px 2px;
-}
-
 #urlbar-search-footer {
   border-top: 1px solid var(--panel-separator-color);
   background-color: var(--arrowpanel-dimmed);
 }
 
 #urlbar-search-settings {
   -moz-appearance: none;
   -moz-user-focus: ignore;