Bug 808410 - Make peptest's checkForCrashes more consistent with the version in automationutils.py; r=jmaher
authorEd Morley <emorley@mozilla.com>
Tue, 20 Nov 2012 15:24:28 +0000
changeset 113779 966b4616dfac55f5fd6910206bc7fe555fea7936
parent 113778 55ea556dffb9d3fbaa489e8a6e7984d2e6645492
child 113780 470669b03c2f8af132192e39ee976c7f4eefc57e
push id23890
push userryanvm@gmail.com
push dateWed, 21 Nov 2012 02:43:32 +0000
treeherdermozilla-central@4f19e7fd8bea [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjmaher
bugs808410
milestone20.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 808410 - Make peptest's checkForCrashes more consistent with the version in automationutils.py; r=jmaher
testing/peptest/peptest/runpeptests.py
--- a/testing/peptest/peptest/runpeptests.py
+++ b/testing/peptest/peptest/runpeptests.py
@@ -167,25 +167,25 @@ class Peptest():
         stackwalkPath = os.environ.get('MINIDUMP_STACKWALK', None)
         # try to get the caller's filename if no test name is given
         if testName is None:
             try:
                 testName = os.path.basename(sys._getframe(1).f_code.co_filename)
             except:
                 testName = "unknown"
 
-        foundCrash = False
         dumpDir = os.path.join(self.profile.profile, 'minidumps')
         dumps = glob.glob(os.path.join(dumpDir, '*.dmp'))
+        if len(dumps) == 0:
+            return False
 
         symbolsPath = self.options.symbolsPath
 
         for d in dumps:
             import subprocess
-            foundCrash = True
             self.logger.info("PROCESS-CRASH | %s | application crashed (minidump found)", testName)
             print "Crash dump filename: " + d
 
             # only proceed if a symbols path and stackwalk path were specified
             if symbolsPath and stackwalkPath and os.path.exists(stackwalkPath):
                 # if symbolsPath is a url, download and extract the zipfile
                 if utils.isURL(symbolsPath):
                     bundle = utils.download(symbolsPath, here)
@@ -208,17 +208,17 @@ class Peptest():
             else:
                 self.logger.warning('No symbols_path or stackwalk path specified, can\'t process dump')
                 break
 
         # if the symbols path was downloaded, cleanup after ourselves
         if utils.isURL(self.options.symbolsPath):
             if os.path.exists(symbolsPath):
                 shutil.rmtree(symbolsPath)
-        return foundCrash
+        return True
 
 class FirefoxPeptest(Peptest):
     profile_class = FirefoxProfile
     runner_class = FirefoxRunner
 
 class ThunderbirdPeptest(Peptest):
     profile_class = ThunderbirdProfile
     runner_class = ThunderbirdRunner