Check the proper pointer. r+sr=biesi. No bug
authorsdwilsh@shawnwilsher.com
Mon, 23 Jul 2007 18:14:56 -0700
changeset 3807 95af236e51595ba1a6cf096c4ed43baa5653655c
parent 3806 2c16d4773ff4e7647d818e326eae2334ede3834e
child 3808 e6ab3de32462885721fc284104ae1c43525ae740
push id1
push userbsmedberg@mozilla.com
push dateThu, 20 Mar 2008 16:49:24 +0000
treeherdermozilla-central@61007906a1f8 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
milestone1.9a7pre
Check the proper pointer. r+sr=biesi. No bug
uriloader/exthandler/nsExternalHelperAppService.cpp
--- a/uriloader/exthandler/nsExternalHelperAppService.cpp
+++ b/uriloader/exthandler/nsExternalHelperAppService.cpp
@@ -1481,17 +1481,17 @@ nsExternalHelperAppService::GetProtocolH
   // XXX enterprise customers should be able to turn this support off with a
   // single master pref (maybe use one of the "exposed" prefs here?)
 
   // nsIMIMEInfo is a superset of nsIHandlerInfo.  Furthermore, nsMimeInfoImpl
   // and subclasses have lots of good platform specific-knowledge of local
   // applications which we might need later.  For now, just use nsMIMEInfoImpl
   // instead of implementating a separate nsIHandlerInfo object.
   *aHandlerInfo = GetProtocolInfoFromOS(aScheme).get();
-  if (!aHandlerInfo) {
+  if (!(*aHandlerInfo)) {
     // Either it knows nothing, or we ran out of memory
     return NS_ERROR_FAILURE;
   }
 
   nsresult rv = FillProtoInfoForSchemeFromDS(aScheme, *aHandlerInfo);     
   if (NS_ERROR_NOT_AVAILABLE == rv) {
     // We don't know it, so we always ask the user.  By the time we call this
     // method, we already have checked if we should open this protocol and ask