Bug 1520132 - Ensure base widget pointer is null on Destroy() r=snorp
authorRandall Barker <rbarker@mozilla.com>
Mon, 11 Feb 2019 21:22:16 +0000
changeset 458741 9571930df748
parent 458740 87dac4d84c6b
child 458742 e0fbd0f5aab7
push id35548
push useropoprus@mozilla.com
push dateWed, 13 Feb 2019 09:48:26 +0000
treeherdermozilla-central@93e37c529818 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerssnorp
bugs1520132
milestone67.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1520132 - Ensure base widget pointer is null on Destroy() r=snorp Speculative fix for crash. Differential Revision: https://phabricator.services.mozilla.com/D19321
gfx/layers/ipc/UiCompositorControllerChild.cpp
--- a/gfx/layers/ipc/UiCompositorControllerChild.cpp
+++ b/gfx/layers/ipc/UiCompositorControllerChild.cpp
@@ -173,16 +173,17 @@ void UiCompositorControllerChild::Destro
         NewRunnableMethod("layers::UiCompositorControllerChild::Destroy", this,
                           &UiCompositorControllerChild::Destroy),
         nsIThread::DISPATCH_SYNC);
     return;
   }
 
   if (mIsOpen) {
     // Close the underlying IPC channel.
+    mWidget = nullptr;
     PUiCompositorControllerChild::Close();
     mIsOpen = false;
   }
 }
 
 void UiCompositorControllerChild::SetBaseWidget(nsBaseWidget* aWidget) {
   mWidget = aWidget;
 }