Bug 1399116 - browser_google_*codes.js don't need to show the search bar in their tests. Remove showing it to help avoid intermittents. r=Paolo
☠☠ backed out by 069a976024ce ☠ ☠
authorMark Banner <standard8@mozilla.com>
Mon, 09 Oct 2017 14:20:50 +0100
changeset 385295 95618704ca66ba13fe1a25e359fadf138506c53b
parent 385294 5ccff8bf69d68a68414a6b4714c0ec7266ee966c
child 385296 3a39810332596996b486b1c3bfc63546c64ed283
push id32652
push userarchaeopteryx@coole-files.de
push dateTue, 10 Oct 2017 21:49:31 +0000
treeherdermozilla-central@f1ecd5c26948 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersPaolo
bugs1399116
milestone58.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1399116 - browser_google_*codes.js don't need to show the search bar in their tests. Remove showing it to help avoid intermittents. r=Paolo MozReview-Commit-ID: 2ovv1ckOvwb
browser/components/search/test/browser_google_codes.js
browser/components/search/test/browser_google_nocodes.js
--- a/browser/components/search/test/browser_google_codes.js
+++ b/browser/components/search/test/browser_google_codes.js
@@ -115,22 +115,16 @@ add_task(async function preparation() {
     waitForSearchNotification("write-cache-to-disk-complete", resolve);
   });
 });
 
 add_task(async function tests() {
   let engine = Services.search.getEngineByName("Google");
   ok(engine, "Google");
 
-  // Show the search bar after initializing the search service, to avoid the
-  // synchronous initialization to interfere.
-  await SpecialPowers.pushPrefEnv({ set: [
-    ["browser.search.widget.inNavBar", true],
-  ]});
-
   let base = "https://www.google.com/search?q=foo&ie=utf-8&oe=utf-8&client=firefox-b";
 
   // Keyword uses a slightly different code
   let keywordBase = base + "-ab";
 
   let url;
 
   // Test search URLs (including purposes).
--- a/browser/components/search/test/browser_google_nocodes.js
+++ b/browser/components/search/test/browser_google_nocodes.js
@@ -115,22 +115,16 @@ add_task(async function preparation() {
     waitForSearchNotification("write-cache-to-disk-complete", resolve);
   });
 });
 
 add_task(async function tests() {
   let engine = Services.search.getEngineByName("Google");
   ok(engine, "Google");
 
-  // Show the search bar after initializing the search service, to avoid the
-  // synchronous initialization to interfere.
-  await SpecialPowers.pushPrefEnv({ set: [
-    ["browser.search.widget.inNavBar", true],
-  ]});
-
   let base = "https://www.google.com/search?q=foo&ie=utf-8&oe=utf-8";
 
   let url;
 
   // Test search URLs (including purposes).
   url = engine.getSubmission("foo", null, "contextmenu").uri.spec;
   is(url, base, "Check context menu search URL for 'foo'");
   url = engine.getSubmission("foo", null, "keyword").uri.spec;