Bug 1092333 - nsDOMStringMap::NamedDeleter doesn't always write its out-parameter. r=bzbarsky.
authorJulian Seward <jseward@acm.org>
Tue, 04 Nov 2014 10:11:08 +0100
changeset 213908 954632f3b2d65bd82a1d8257557c4a81b4d1a570
parent 213907 619279d965d199fe13c028f49944371a9271e626
child 213909 a27e38c36cb0832a5d0e51ab6cf341bae5159032
push id27768
push userkwierso@gmail.com
push dateWed, 05 Nov 2014 02:19:03 +0000
treeherdermozilla-central@a1823d3c7365 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersbzbarsky
bugs1092333
milestone36.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1092333 - nsDOMStringMap::NamedDeleter doesn't always write its out-parameter. r=bzbarsky.
dom/html/nsDOMStringMap.cpp
--- a/dom/html/nsDOMStringMap.cpp
+++ b/dom/html/nsDOMStringMap.cpp
@@ -121,21 +121,23 @@ nsDOMStringMap::NamedSetter(const nsAStr
   }
 }
 
 void
 nsDOMStringMap::NamedDeleter(const nsAString& aProp, bool& found)
 {
   // Currently removing property, attribute is already removed.
   if (mRemovingProp) {
+    found = false;
     return;
   }
   
   nsAutoString attr;
   if (!DataPropToAttr(aProp, attr)) {
+    found = false;
     return;
   }
 
   nsCOMPtr<nsIAtom> attrAtom = do_GetAtom(attr);
   MOZ_ASSERT(attrAtom, "Should be infallible");
 
   found = mElement->HasAttr(kNameSpaceID_None, attrAtom);