Bug 1368948: [5/7] Suppress clang-plugin errors. r=Ehsan
authorBruce Sun <brsun@mozilla.com>
Thu, 29 Jun 2017 17:16:38 -0700
changeset 367056 95400bc93b906e036eeb2357a9c9b05369c0fd99
parent 367055 9adc0e3d0d915c632f01f6ba8ac3637cca8470ff
child 367057 31e471d5b2896cbbfddb0025fb872532cf841bc4
push id32117
push userphilringnalda@gmail.com
push dateSun, 02 Jul 2017 00:39:30 +0000
treeherdermozilla-central@4d3de12dcdc5 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersEhsan
bugs1368948
milestone56.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1368948: [5/7] Suppress clang-plugin errors. r=Ehsan MozReview-Commit-ID: 3uJHP2oerqK
build/clang-plugin/Utils.h
tools/rewriting/ThirdPartyPaths.txt
--- a/build/clang-plugin/Utils.h
+++ b/build/clang-plugin/Utils.h
@@ -156,17 +156,18 @@ inline bool isInIgnoredNamespaceForImpli
          Name == "google" ||            // protobuf
          Name == "google_breakpad" ||   // breakpad
          Name == "soundtouch" ||        // libsoundtouch
          Name == "stagefright" ||       // libstagefright
          Name == "MacFileUtilities" ||  // MacFileUtilities
          Name == "dwarf2reader" ||      // dwarf2reader
          Name == "arm_ex_to_module" ||  // arm_ex_to_module
          Name == "testing" ||           // gtest
-         Name == "Json";                // jsoncpp
+         Name == "Json" ||              // jsoncpp
+         Name == "pdfium";              // upstream pdfium 'base' package
 }
 
 inline bool isInIgnoredNamespaceForImplicitConversion(const Decl *Declaration) {
   std::string Name = getDeclarationNamespace(Declaration);
   if (Name == "") {
     return false;
   }
 
@@ -189,17 +190,18 @@ inline bool isIgnoredPathForImplicitCtor
         Begin->compare_lower(StringRef("angle")) == 0 ||
         Begin->compare_lower(StringRef("harfbuzz")) == 0 ||
         Begin->compare_lower(StringRef("hunspell")) == 0 ||
         Begin->compare_lower(StringRef("scoped_ptr.h")) == 0 ||
         Begin->compare_lower(StringRef("graphite2")) == 0 ||
         Begin->compare_lower(StringRef("icu")) == 0 ||
         Begin->compare_lower(StringRef("libcubeb")) == 0 ||
         Begin->compare_lower(StringRef("libstagefright")) == 0 ||
-        Begin->compare_lower(StringRef("cairo")) == 0) {
+        Begin->compare_lower(StringRef("cairo")) == 0 ||
+        Begin->compare_lower(StringRef("pdfium")) == 0) {
       return true;
     }
     if (Begin->compare_lower(StringRef("chromium")) == 0) {
       // Ignore security/sandbox/chromium but not ipc/chromium.
       ++Begin;
       return Begin != End && Begin->compare_lower(StringRef("sandbox")) == 0;
     }
   }
@@ -242,17 +244,18 @@ inline bool isIgnoredPathForSprintfLiter
         Begin->compare_lower(StringRef("harfbuzz")) == 0 ||
         Begin->compare_lower(StringRef("jsoncpp")) == 0 ||
         Begin->compare_lower(StringRef("libstagefright")) == 0 ||
         Begin->compare_lower(StringRef("mtransport")) == 0 ||
         Begin->compare_lower(StringRef("protobuf")) == 0 ||
         Begin->compare_lower(StringRef("skia")) == 0 ||
         Begin->compare_lower(StringRef("sfntly")) == 0 ||
         // Gtest uses snprintf as GTEST_SNPRINTF_ with sizeof
-        Begin->compare_lower(StringRef("testing")) == 0) {
+        Begin->compare_lower(StringRef("testing")) == 0 ||
+        Begin->compare_lower(StringRef("pdfium")) == 0) {
       return true;
     }
     if (Begin->compare_lower(StringRef("webrtc")) == 0) {
       // Ignore trunk/webrtc, but not media/webrtc
       ++Begin;
       return Begin != End && Begin->compare_lower(StringRef("trunk")) == 0;
     }
   }
--- a/tools/rewriting/ThirdPartyPaths.txt
+++ b/tools/rewriting/ThirdPartyPaths.txt
@@ -49,16 +49,17 @@ mfbt/double-conversion/source/
 mfbt/lz4
 mobile/android/geckoview/src/thirdparty/
 mobile/android/thirdparty/
 modules/brotli/
 modules/fdlibm/
 modules/freetype2/
 modules/libbz2/
 modules/libmar/
+modules/pdfium/
 modules/woff2/
 modules/zlib/
 netwerk/sctp/src/
 netwerk/srtp/src/
 nsprpub/
 other-licenses/
 parser/expat/
 security/nss/