Bug 1510440 - Skip breakpoints fails when devtools is re-opened r=davidwalsh
authorJason Laster <jlaster@mozilla.com>
Wed, 28 Nov 2018 18:53:26 +0000
changeset 448554 94b6dac6695dff0236560b2ee92ea0fb749e2e0e
parent 448553 d943368c547a12ec273f0d71b21ddc90e1ff3062
child 448555 f5322374274449092b3578d5e844f862d077e109
push id35119
push userccoroiu@mozilla.com
push dateThu, 29 Nov 2018 04:26:53 +0000
treeherdermozilla-central@c35dea45f131 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersdavidwalsh
bugs1510440
milestone65.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1510440 - Skip breakpoints fails when devtools is re-opened r=davidwalsh Differential Revision: https://phabricator.services.mozilla.com/D13140
devtools/client/debugger/new/src/client/firefox.js
devtools/server/actors/thread.js
--- a/devtools/client/debugger/new/src/client/firefox.js
+++ b/devtools/client/debugger/new/src/client/firefox.js
@@ -1,17 +1,17 @@
 /* This Source Code Form is subject to the terms of the Mozilla Public
  * License, v. 2.0. If a copy of the MPL was not distributed with this
  * file, You can obtain one at <http://mozilla.org/MPL/2.0/>. */
 
 // @flow
 
 import { setupCommands, clientCommands } from "./firefox/commands";
 import { setupEvents, clientEvents } from "./firefox/events";
-import { features } from "../utils/prefs";
+import { features, prefs } from "../utils/prefs";
 import type { Grip } from "../types";
 let DebuggerClient;
 
 function createObjectClient(grip: Grip) {
   return DebuggerClient.createObjectClient(grip);
 }
 
 export async function onConnect(connection: any, actions: Object): Object {
@@ -39,17 +39,18 @@ export async function onConnect(connecti
     setupEvents({ threadClient, actions, supportsWasm });
   }
 
   tabTarget.on("will-navigate", actions.willNavigate);
   tabTarget.on("navigate", actions.navigated);
 
   await threadClient.reconfigure({
     observeAsmJS: true,
-    wasmBinarySource: supportsWasm
+    wasmBinarySource: supportsWasm,
+    skipBreakpoints: prefs.skipPausing
   });
 
   // In Firefox, we need to initially request all of the sources. This
   // usually fires off individual `newSource` notifications as the
   // debugger finds them, but there may be existing sources already in
   // the debugger (if it's paused already, or if loading the page from
   // bfcache) so explicity fire `newSource` events for all returned
   // sources.
--- a/devtools/server/actors/thread.js
+++ b/devtools/server/actors/thread.js
@@ -435,16 +435,20 @@ const ThreadActor = ActorClassWithSpec(t
       return { error: "wrongState" };
     }
     const options = request.options || {};
 
     if ("observeAsmJS" in options) {
       this.dbg.allowUnobservedAsmJS = !options.observeAsmJS;
     }
 
+    if ("skipBreakpoints" in options) {
+      this.skipBreakpoints = options.skipBreakpoints;
+    }
+
     Object.assign(this._options, options);
 
     // Update the global source store
     this.sources.setOptions(options);
 
     return {};
   },