Backed out changeset 4ad8241eb92a (bug 1511398) gv-junit2 crashes on [@ mozilla::a11y::Accessible::IsDefunct() const] . CLOSED TREE
authorNarcis Beleuzu <nbeleuzu@mozilla.com>
Wed, 05 Dec 2018 22:06:21 +0200
changeset 449459 945ae1cf83ec8dd7c811044f8cabf52c0252bfd8
parent 449458 d7d78e79f0b34d84ba17ebd5311989cee49b5b6c
child 449460 4e65e04a0d2bdfa613ee1623b7bd6bd1003a152b
push id35164
push usershindli@mozilla.com
push dateThu, 06 Dec 2018 04:02:49 +0000
treeherdermozilla-central@d932537fec3b [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
bugs1511398
milestone65.0a1
backs out4ad8241eb92a80771580ac497e4e4c2468f861da
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Backed out changeset 4ad8241eb92a (bug 1511398) gv-junit2 crashes on [@ mozilla::a11y::Accessible::IsDefunct() const] . CLOSED TREE
accessible/android/SessionAccessibility.cpp
--- a/accessible/android/SessionAccessibility.cpp
+++ b/accessible/android/SessionAccessibility.cpp
@@ -1,14 +1,13 @@
 /* -*- Mode: c++; c-basic-offset: 2; tab-width: 20; indent-tabs-mode: nil; -*-
  * This Source Code Form is subject to the terms of the Mozilla Public
  * License, v. 2.0. If a copy of the MPL was not distributed with this
  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
 
-#include "Accessible-inl.h"
 #include "SessionAccessibility.h"
 #include "AndroidUiThread.h"
 #include "DocAccessibleParent.h"
 #include "nsThreadUtils.h"
 #include "AccessibilityEvent.h"
 #include "HyperTextAccessible.h"
 #include "JavaBuiltins.h"
 #include "RootAccessibleWrap.h"
@@ -367,25 +366,19 @@ void SessionAccessibility::ReplaceFocusP
 }
 
 void SessionAccessibility::UpdateCachedBounds(
     const nsTArray<AccessibleWrap*>& aAccessibles,
     const nsTArray<BatchData>& aData) {
   auto infos = jni::ObjectArray::New<java::GeckoBundle>(aAccessibles.Length());
   for (size_t i = 0; i < aAccessibles.Length(); i++) {
     AccessibleWrap* acc = aAccessibles.ElementAt(i);
-    if (!acc || acc->IsDefunct()) {
-      MOZ_ASSERT_UNREACHABLE("Updated accessible is gone.");
-      continue;
-    }
-
     if (aData.Length() == aAccessibles.Length()) {
       const BatchData& data = aData.ElementAt(i);
-      auto bundle =
-          acc->ToSmallBundle(data.State(), data.Bounds(), data.ActionCount());
+      auto bundle = acc->ToSmallBundle(data.State(), data.Bounds(), data.ActionCount());
       infos->SetElement(i, bundle);
     } else {
       infos->SetElement(i, acc->ToSmallBundle());
     }
   }
 
   mSessionAccessibility->UpdateCachedBounds(infos);
 }