Backed out changeset 73bd8f2fbbf1 (bug 1664020) for bustages complaining about CacheFileIOManager.cpp CLOSED TREE
authorBogdan Tara <btara@mozilla.com>
Fri, 11 Sep 2020 16:10:19 +0300
changeset 548319 941862090875537f3cbadc0fbbae6e77535fcc26
parent 548318 c8322fb7a54aed137bb6db2f5a62087113dd721c
child 548320 4123a3bc61731cf965e0973263467534238a9393
push id37777
push userapavel@mozilla.com
push dateFri, 11 Sep 2020 21:38:12 +0000
treeherdermozilla-central@941862090875 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
bugs1664020
milestone82.0a1
backs out73bd8f2fbbf1831371423d48283be6aa791e7f12
first release with
nightly linux32
941862090875 / 82.0a1 / 20200911213812 / files
nightly linux64
941862090875 / 82.0a1 / 20200911213812 / files
nightly mac
941862090875 / 82.0a1 / 20200911213812 / files
nightly win32
941862090875 / 82.0a1 / 20200911213812 / files
nightly win64
941862090875 / 82.0a1 / 20200911213812 / files
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
releases
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Backed out changeset 73bd8f2fbbf1 (bug 1664020) for bustages complaining about CacheFileIOManager.cpp CLOSED TREE
netwerk/cache2/CacheFileIOManager.cpp
--- a/netwerk/cache2/CacheFileIOManager.cpp
+++ b/netwerk/cache2/CacheFileIOManager.cpp
@@ -545,23 +545,16 @@ class ShutdownEvent : public Runnable {
     MonitorAutoLock mon(mMonitor);
 
     DebugOnly<nsresult> rv;
     rv = CacheFileIOManager::gInstance->mIOThread->Dispatch(
         this,
         CacheIOThread::WRITE);  // When writes and closing of handles is done
     MOZ_ASSERT(NS_SUCCEEDED(rv));
 
-    // If we failed to post the even there's no reason to go into the loop
-    // because mNotified will never be set to true.
-    if (NS_FAILED(rv)) {
-      NS_WARNING("Posting ShutdownEvent task failed");
-      return;
-    }
-
     TimeDuration waitTime = TimeDuration::FromSeconds(1);
     while (!mNotified) {
       mon.Wait(waitTime);
       if (!mNotified) {
         // If there is any IO blocking on the IO thread, this will
         // try to cancel it.  Returns no later than after two seconds.
         MonitorAutoUnlock unmon(mMonitor);  // Prevent delays
         CacheFileIOManager::gInstance->mIOThread->CancelBlockingIO();