Backout Bug 149075 - While it is compatible with the SVG specification, all other browsers allow it
authorRobert Longson <longsonr@gmail.com>
Sat, 28 Apr 2018 16:09:38 +0100
changeset 416203 9263d25afcd041bf301cbd96c4cb8199975c85bf
parent 416202 254e0c58f80fd65ad00bcd3b4dfd324a05d93e67
child 416204 eb408f77a028cd93809fadb30f101fbf4aaa4d70
push id33919
push usernerli@mozilla.com
push dateSun, 29 Apr 2018 09:48:23 +0000
treeherdermozilla-central@c552490c8659 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
bugs149075
milestone61.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Backout Bug 149075 - While it is compatible with the SVG specification, all other browsers allow it
dom/svg/SVGTransformListParser.cpp
layout/reftests/svg/reftest.list
layout/reftests/svg/transform-01.svg
--- a/dom/svg/SVGTransformListParser.cpp
+++ b/dom/svg/SVGTransformListParser.cpp
@@ -109,33 +109,25 @@ SVGTransformListParser::ParseArguments(f
     return false;
   }
 
   if (!SVGContentUtils::ParseNumber(mIter, mEnd, aResult[0])) {
     return false;
   }
   *aParsedCount = 1;
 
-  while (true) {
-    RangedPtr<const char16_t> iter(mIter);
-    if (!SkipWsp()) {
-      return false;
-    }
+  while (SkipWsp()) {
     if (*mIter == ')') {
       ++mIter;
       return true;
     }
     if (*aParsedCount == aMaxCount) {
       return false;
     }
     SkipCommaWsp();
-    if (iter == mIter) {
-      // There must be either whitespace or a comma between values
-      return false;
-    }
     if (!SVGContentUtils::ParseNumber(mIter, mEnd, aResult[(*aParsedCount)++])) {
       return false;
     }
   }
   return false;
 }
 
 bool
--- a/layout/reftests/svg/reftest.list
+++ b/layout/reftests/svg/reftest.list
@@ -479,17 +479,16 @@ fuzzy-if(skiaContent,1,610) == textPath-
 == textPath-line-01.svg textPath-line-01-ref.svg
 == textPath-path-attribute-01.svg textPath-path-attribute-01-ref.svg
 == textPath-side-attribute-01.svg pass.svg
 
 == text-white-space-01.svg text-white-space-01-ref.svg
 
 == thin-stroke-01.svg pass.svg
 
-== transform-01.svg pass.svg
 == transform-outer-svg-01.svg transform-outer-svg-01-ref.svg
 
 == tspan-dxdy-01.svg tspan-dxdy-ref.svg
 == tspan-dxdy-02.svg tspan-dxdy-ref.svg
 == tspan-dxdy-03.svg tspan-dxdy-ref.svg
 == tspan-dxdy-04.svg tspan-dxdy-ref.svg
 == tspan-dxdy-05.svg tspan-dxdy-ref.svg
 == tspan-dxdy-06.svg tspan-dxdy-ref.svg
deleted file mode 100644
--- a/layout/reftests/svg/transform-01.svg
+++ /dev/null
@@ -1,11 +0,0 @@
-<!--
-     Any copyright is dedicated to the Public Domain.
-     http://creativecommons.org/publicdomain/zero/1.0/
--->
-<svg xmlns="http://www.w3.org/2000/svg">
-  <rect width="100%" height="100%" fill="lime"/>
-  <rect x="25" y="25" width="50" height="50" fill="red"/>
-  <g transform="translate(-100-100)">
-    <rect x="24" y="24" width="52" height="52" fill="lime"/>
-  </g>
-</svg>