Bug 1510030 - Don't return the current opacity value from update_opacity_binding. r=gw
☠☠ backed out by 7fc17499b720 ☠ ☠
authorHiroyuki Ikezoe <hikezoe.birchill@mozilla.com>
Thu, 27 Feb 2020 02:04:21 +0000
changeset 515817 921116ca67a59fb323b74d1a610249c2448101d7
parent 515816 f407f21e0921db4120696b843566f206ea8b38e0
child 515818 737f4bc3afd3e823fd3f0e253388789a8c0d0299
push id37162
push usernbeleuzu@mozilla.com
push dateThu, 27 Feb 2020 09:49:56 +0000
treeherdermozilla-central@9e8d5431c412 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersgw
bugs1510030
milestone75.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1510030 - Don't return the current opacity value from update_opacity_binding. r=gw The return value is not used at all. Differential Revision: https://phabricator.services.mozilla.com/D63600
gfx/wr/webrender/src/prim_store/mod.rs
--- a/gfx/wr/webrender/src/prim_store/mod.rs
+++ b/gfx/wr/webrender/src/prim_store/mod.rs
@@ -4301,23 +4301,20 @@ pub fn get_line_decoration_size(
         LineOrientation::Vertical => LayoutSize::new(perpendicular, parallel),
     })
 }
 
 fn update_opacity_binding(
     opacity_bindings: &mut OpacityBindingStorage,
     opacity_binding_index: OpacityBindingIndex,
     scene_properties: &SceneProperties,
-) -> f32 {
-    if opacity_binding_index == OpacityBindingIndex::INVALID {
-        1.0
-    } else {
+) {
+    if opacity_binding_index != OpacityBindingIndex::INVALID {
         let binding = &mut opacity_bindings[opacity_binding_index];
         binding.update(scene_properties);
-        binding.current
     }
 }
 
 /// Trait for primitives that are directly internable.
 /// see SceneBuilder::add_primitive<P>
 pub trait InternablePrimitive: intern::Internable<InternData = PrimitiveSceneData> + Sized {
     /// Build a new key from self with `info`.
     fn into_key(