mozilla-central: changeset 306168:920b164008c2fd1912761a7625c16e1e80d9e094

author	Nathan Froyd <froydnj@gmail.com>
	Thu, 21 Jul 2016 16:45:24 -0400
changeset 306168	920b164008c2fd1912761a7625c16e1e80d9e094
parent 306167	eb74a01c8dc0bc508ea8b492e6a4c179e1c2ff19
child 306169	d7988da78c417062fd44170fe8881308b9803dbc
push id	30480
push user	cbook@mozilla.com
push date	Fri, 22 Jul 2016 09:58:20 +0000
treeherder	mozilla-central@e0bc88708ffe [default view] [failures only]
perfherder	[talos] [build metrics] [platform microbench] (compared to previous push)
reviewers	botond
bugs	1287785
milestone	50.0a1
first release with	nightly linux32 e0bc88708ffe / 50.0a1 / 20160724030208 / files nightly linux64 e0bc88708ffe / 50.0a1 / 20160724030208 / files nightly mac e0bc88708ffe / 50.0a1 / 20160724030208 / files nightly win32 e0bc88708ffe / 50.0a1 / 20160724030208 / files nightly win64 e0bc88708ffe / 50.0a1 / 20160724030208 / files
last release without	nightly linux32 d224fc999cb6 / 50.0a1 / 20160721030216 / files nightly linux64 d224fc999cb6 / 50.0a1 / 20160721030216 / files nightly mac d224fc999cb6 / 50.0a1 / 20160721030216 / files nightly win32 d224fc999cb6 / 50.0a1 / 20160721030216 / files nightly win64 d224fc999cb6 / 50.0a1 / 20160721030216 / files

Bug 1287785 - avoid copying ScrollMetadata values in RenderLayers; r=botond Using `auto' here means that we're copying each ScrollMetadata value as we examine it. Using `auto&' here means that we don't copy, which is probably the intended behavior.

gfx/layers/composite/ContainerLayerComposite.cpp

file | annotate | diff | comparison | revisions

--- a/gfx/layers/composite/ContainerLayerComposite.cpp
+++ b/gfx/layers/composite/ContainerLayerComposite.cpp
@@ -594,17 +594,17 @@ RenderLayers(ContainerT* aContainer,
     const RenderTargetIntRect& clipRect = preparedData.mClipRect;
     Layer* layer = layerToRender->GetLayer();
 
     if (layerToRender->HasStaleCompositor()) {
       continue;
     }
 
     if (gfxPrefs::LayersDrawFPS()) {
-      for (auto metadata : layer->GetAllScrollMetadata()) {
+      for (const auto& metadata : layer->GetAllScrollMetadata()) {
         if (metadata.IsApzForceDisabled()) {
           aManager->DisabledApzWarning();
           break;
         }
       }
     }
 
     Color color;