Bug 1185886: P1. Ensure DrainComplete() is called when draining. r=cpearce
authorJean-Yves Avenard <jyavenard@mozilla.com>
Sun, 26 Jul 2015 21:28:48 +1000
changeset 254634 91de55bfe09a037364b9e4a8947e97eecc6054e1
parent 254633 d4b6f85c0d420e6dabffc33c8ff4bc216cbb4272
child 254635 6681786341a9dd54171d30ede88538cece2c3f8f
push id29108
push userryanvm@gmail.com
push dateMon, 27 Jul 2015 14:12:01 +0000
treeherdermozilla-central@27ae736ef960 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerscpearce
bugs1185886
milestone42.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1185886: P1. Ensure DrainComplete() is called when draining. r=cpearce If no samples were ever passed to the H264 wrapper, no decoder would have been created.
dom/media/platforms/wrappers/H264Converter.cpp
--- a/dom/media/platforms/wrappers/H264Converter.cpp
+++ b/dom/media/platforms/wrappers/H264Converter.cpp
@@ -90,16 +90,17 @@ H264Converter::Flush()
 }
 
 nsresult
 H264Converter::Drain()
 {
   if (mDecoder) {
     return mDecoder->Drain();
   }
+  mCallback->DrainComplete();
   return mLastError;
 }
 
 nsresult
 H264Converter::Shutdown()
 {
   if (mDecoder) {
     nsresult rv = mDecoder->Shutdown();