Bug 1503420 Part 1 - Adjust some callers of nsIFrame::List() to stop passing 0 as a const char* argument. r=dholbert
authorTing-Yu Lin <tlin@mozilla.com>
Wed, 09 Jan 2019 21:02:13 +0000
changeset 453962 918042a8eb34fe65335f96b5ae1226409361d4f6
parent 453961 e68c233270e3f59cc1862f5570a0bd21376e9d34
child 453963 3eafb595be4fce04627edba4b9686ac44baed45f
push id35382
push userdvarga@mozilla.com
push dateWed, 16 Jan 2019 04:47:18 +0000
treeherdermozilla-central@b46d5d689c8d [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersdholbert
bugs1503420
milestone66.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1503420 Part 1 - Adjust some callers of nsIFrame::List() to stop passing 0 as a const char* argument. r=dholbert To reproduce, execute "GECKO_FRAMECTOR_DEBUG_FLAGS=really-noisy-content-updates ./mach run". nsIFrame::List()'s second argument should be a const char*, not an integer. We can fix the bug by omitting it because the default value of the argument is an empty string. Differential Revision: https://phabricator.services.mozilla.com/D16075
layout/base/PresShell.cpp
layout/base/nsCSSFrameConstructor.cpp
--- a/layout/base/PresShell.cpp
+++ b/layout/base/PresShell.cpp
@@ -9369,19 +9369,19 @@ bool PresShell::VerifyIncrementalReflow(
 
   // Now that the document has been reflowed, use its frame tree to
   // compare against our frame tree.
   nsIFrame* root1 = mFrameConstructor->GetRootFrame();
   nsIFrame* root2 = sh->GetRootFrame();
   bool ok = CompareTrees(mPresContext, root1, cx, root2);
   if (!ok && (VERIFY_REFLOW_NOISY & gVerifyReflowFlags)) {
     printf("Verify reflow failed, primary tree:\n");
-    root1->List(stdout, 0);
+    root1->List(stdout);
     printf("Verification tree:\n");
-    root2->List(stdout, 0);
+    root2->List(stdout);
   }
 
 #if 0
   // Sample code for dumping page to png
   // XXX Needs to be made more flexible
   if (!ok) {
     nsString stra;
     static int num = 0;
--- a/layout/base/nsCSSFrameConstructor.cpp
+++ b/layout/base/nsCSSFrameConstructor.cpp
@@ -6855,17 +6855,17 @@ void nsCSSFrameConstructor::ContentAppen
   // Recover first-letter frames
   if (haveFirstLetterStyle) {
     RecoverLetterFrames(containingBlock);
   }
 
 #ifdef DEBUG
   if (gReallyNoisyContentUpdates) {
     printf("nsCSSFrameConstructor::ContentAppended: resulting frame model:\n");
-    parentFrame->List(stdout, 0);
+    parentFrame->List(stdout);
   }
 #endif
 
 #ifdef ACCESSIBILITY
   if (nsAccessibilityService* accService = nsIPresShell::AccService()) {
     accService->ContentRangeInserted(mPresShell, aFirstNewContent, nullptr);
   }
 #endif
@@ -6958,17 +6958,17 @@ void nsCSSFrameConstructor::ContentRange
     // Create frames for the document element and its child elements
     if (ConstructDocElementFrame(docElement, aFrameState)) {
       InvalidateCanvasIfNeeded(mPresShell, aStartChild);
 #ifdef DEBUG
       if (gReallyNoisyContentUpdates) {
         printf(
             "nsCSSFrameConstructor::ContentRangeInserted: resulting frame "
             "model:\n");
-        mRootElementFrame->List(stdout, 0);
+        mRootElementFrame->List(stdout);
       }
 #endif
     }
 
     if (aFrameState) {
       // Restore frame state for the root scroll frame if there is one
       if (nsIFrame* rootScrollFrame = mPresShell->GetRootScrollFrame()) {
         RestoreFrameStateFor(rootScrollFrame, aFrameState);
@@ -7320,17 +7320,17 @@ void nsCSSFrameConstructor::ContentRange
     RecoverLetterFrames(state.mFloatedItems.containingBlock);
   }
 
 #ifdef DEBUG
   if (gReallyNoisyContentUpdates && insertion.mParentFrame) {
     printf(
         "nsCSSFrameConstructor::ContentRangeInserted: resulting frame "
         "model:\n");
-    insertion.mParentFrame->List(stdout, 0);
+    insertion.mParentFrame->List(stdout);
   }
 #endif
 
 #ifdef ACCESSIBILITY
   if (nsAccessibilityService* accService = nsIPresShell::AccService()) {
     accService->ContentRangeInserted(mPresShell, aStartChild, aEndChild);
   }
 #endif
@@ -7576,17 +7576,17 @@ bool nsCSSFrameConstructor::ContentRemov
 #endif
     }
 
 #ifdef DEBUG
     if (gReallyNoisyContentUpdates) {
       printf("nsCSSFrameConstructor::ContentRemoved: childFrame=");
       nsFrame::ListTag(stdout, childFrame);
       putchar('\n');
-      parentFrame->List(stdout, 0);
+      parentFrame->List(stdout);
     }
 #endif
 
     // Notify the parent frame that it should delete the frame
     if (childFrame->GetStateBits() & NS_FRAME_OUT_OF_FLOW) {
       childFrame = childFrame->GetPlaceholderFrame();
       NS_ASSERTION(childFrame, "Missing placeholder frame for out of flow.");
       parentFrame = childFrame->GetParent();
@@ -7647,17 +7647,17 @@ bool nsCSSFrameConstructor::ContentRemov
         ReframeTextIfNeeded(aOldNextSibling);
         LAYOUT_PHASE_TEMP_REENTER();
       }
     }
 
 #ifdef DEBUG
     if (gReallyNoisyContentUpdates && parentFrame) {
       printf("nsCSSFrameConstructor::ContentRemoved: resulting frame model:\n");
-      parentFrame->List(stdout, 0);
+      parentFrame->List(stdout);
     }
 #endif
   }
 
   return false;
 }
 
 /**