Bug 1654589 - Move `libpref` Python unit test to `mozbuild` suite r=froydnj
☠☠ backed out by 074ba1c12600 ☠ ☠
authorRicky Stewart <rstewart@mozilla.com>
Thu, 23 Jul 2020 17:30:18 +0000
changeset 541789 9168828ce9e9e74107bd8a64324981e6d5c70ea7
parent 541788 5acd57b4187dd9dd3a2762f9f6f611b0d32267ed
child 541790 2107c6ef98d811fcf53bab6f3700c33fc2f842bb
push id37633
push userccoroiu@mozilla.com
push dateFri, 24 Jul 2020 09:32:06 +0000
treeherdermozilla-central@141543043270 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersfroydnj
bugs1654589
milestone80.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1654589 - Move `libpref` Python unit test to `mozbuild` suite r=froydnj It could go into its own test suite, but it 1) depends on `mozbuild` code, so the `mozbuild` suite as well as this new suite would be running on any push that touches `mozbuild` code anyway, and 2) this is code that runs during the build, so it's not out of place. Differential Revision: https://phabricator.services.mozilla.com/D84547
modules/libpref/test/python.ini
taskcluster/ci/source-test/python.yml
testing/testsuite-targets.mk
--- a/modules/libpref/test/python.ini
+++ b/modules/libpref/test/python.ini
@@ -1,3 +1,4 @@
 [DEFAULT]
+subsuite = mozbuild
 
 [test_generate_static_pref_list.py]
--- a/taskcluster/ci/source-test/python.yml
+++ b/taskcluster/ci/source-test/python.yml
@@ -364,16 +364,18 @@ mozbuild:
                 windows10-64/opt:
                     - win64-node-10
     when:
         files-changed:
             - '**/moz.configure'
             - 'build/moz.configure/**'
             - 'config/tests/**'
             - 'dom/bindings/mozwebidlcodegen/**'
+            - 'modules/libpref/init/**'
+            - 'modules/libpref/test/**'
             - 'python/mach/**'
             - 'python/mozboot/**'
             - 'python/mozbuild/**'
             - 'python/mozterm/**'
             - 'python/mozversioncontrol/**'
             - 'testing/mozbase/**'
             - 'testing/xpcshell/xpcshellcommandline.py'
 
--- a/testing/testsuite-targets.mk
+++ b/testing/testsuite-targets.mk
@@ -259,20 +259,21 @@ stage-extensions: make-stage-dir
 	@$(foreach ext,$(TEST_EXTENSIONS), cp -RL $(DIST)/xpi-stage/$(ext) $(PKG_STAGE)/extensions;)
 
 
 check::
 	$(eval cores=$(shell $(PYTHON3) -c 'import multiprocessing; print(multiprocessing.cpu_count())'))
 	@echo "Starting 'mach python-test' with -j$(cores)"
 	@$(topsrcdir)/mach --log-no-times python-test -j$(cores) --subsuite default
 	@echo "Finished 'mach python-test' successfully"
+ifeq (,$(MOZ_ASAN)$(MOZ_TSAN))  # No tests run here for asan/tsan builds.
 	@echo "Starting 'mach python-test' with --python $(PYTHON3) -j$(cores)"
 	@$(topsrcdir)/mach --log-no-times python-test --python python3 -j$(cores) --subsuite default
 	@echo "Finished 'mach python-test' with py3 successfully"
-
+endif
 
 .PHONY: \
   reftest \
   crashtest \
   xpcshell-tests \
   jstestbrowser \
   package-tests \
   download-wpt-manifest \