Bug 1637915: use strings for GitIgnoreCache r=rstewart
authorMitchell Hentges <mhentges@mozilla.com>
Wed, 20 May 2020 20:55:54 +0000
changeset 531323 915a6a8561f63c6df7222638be85743e97077cdc
parent 531322 c3ac91c63eeb6037e6c07591d198460703e92279
child 531324 3d91ba9e1d25d47c742436b5aa8bb309fb67b365
push id37437
push usernerli@mozilla.com
push dateThu, 21 May 2020 02:34:41 +0000
treeherdermozilla-central@3d91ba9e1d25 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersrstewart
bugs1637915
milestone78.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1637915: use strings for GitIgnoreCache r=rstewart Differential Revision: https://phabricator.services.mozilla.com/D75363
testing/web-platform/tests/tools/manifest/vcs.py
--- a/testing/web-platform/tests/tools/manifest/vcs.py
+++ b/testing/web-platform/tests/tools/manifest/vcs.py
@@ -221,22 +221,22 @@ class MtimeCache(CacheFile):
         super(MtimeCache, self).dump()
 
 
 class GitIgnoreCache(CacheFile, MutableMapping):  # type: ignore
     file_name = "gitignore.json"
 
     def check_valid(self, data):
         # type: (Dict[Any, Any]) -> Dict[Any, Any]
-        ignore_path = os.path.join(self.tests_root, b".gitignore")
+        ignore_path = os.path.join(self.tests_root, ".gitignore")
         mtime = os.path.getmtime(ignore_path)
-        if data.get(b"/gitignore_file") != [ignore_path, mtime]:
+        if data.get("/gitignore_file") != [ignore_path, mtime]:
             self.modified = True
             data = {}
-            data[b"/gitignore_file"] = [ignore_path, mtime]
+            data["/gitignore_file"] = [ignore_path, mtime]
         return data
 
     def __contains__(self, key):
         # type: (Any) -> bool
         return key in self.data
 
     def __getitem__(self, key):
         # type: (bytes) -> bool