Bug 1454184 [wpt PR 10474] - [Resource Timing] Align TAO parsing to spec, a=testonly
authorYoav Weiss <yoav@yoav.ws>
Fri, 27 Apr 2018 20:54:27 +0000
changeset 416225 90fa6ef8f1202d3f830ab4691ee6c442566cf70a
parent 416224 c5ec60ab9ea8d8152e3989e3c8f6233dfe41cf18
child 416226 6b980ffeab0c61f0eae10fb6cdac204c34f23c63
push id33919
push usernerli@mozilla.com
push dateSun, 29 Apr 2018 09:48:23 +0000
treeherdermozilla-central@c552490c8659 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerstestonly
bugs1454184, 10474, 651861, 833032, 626703, 1013409, 552127
milestone61.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1454184 [wpt PR 10474] - [Resource Timing] Align TAO parsing to spec, a=testonly Automatic update from web-platform-tests[Resource Timing] Align TAO parsing to spec TAO parsing had two issues: * It was splitting the host values on whitespace rather than a comma. This used to be the specified behavior, but changed in https://github.com/w3c/resource-timing/pull/68 * When it was checking the different hosts in the host list, it was not checking for "*" as a possible value. This CL fixes those two issues and aligns the test expectations accordingly. Bug: 651861, 833032, 626703 Change-Id: I8a3b7e705ed7089719ad0f52607363392c7de934 Reviewed-on: https://chromium-review.googlesource.com/1013409 Reviewed-by: Nicolás Peña Moreno <npm@chromium.org> Commit-Queue: Yoav Weiss <yoav@yoav.ws> Cr-Commit-Position: refs/heads/master@{#552127} -- wpt-commits: 19aab25e57073263e2c937370dbb31a8f15feb0f wpt-pr: 10474
testing/web-platform/meta/MANIFEST.json
testing/web-platform/tests/resource-timing/resources/TAOResponse.py
--- a/testing/web-platform/meta/MANIFEST.json
+++ b/testing/web-platform/meta/MANIFEST.json
@@ -596230,17 +596230,17 @@
    "4a108e824fb57aa563deede2da8d47f25a8ab41e",
    "testharness"
   ],
   "resource-timing/resource_timing_store_and_clear_during_callback.html": [
    "dfbd67c249b48f133ec896a291ea0d925307e4ec",
    "testharness"
   ],
   "resource-timing/resources/TAOResponse.py": [
-   "9e8051a2ff8fff72b36ed1cecb61f9e7bba29071",
+   "8d195488cb76f1c17da16d06893d5ebc65550465",
    "support"
   ],
   "resource-timing/resources/all_resource_types.htm": [
    "63a40f0ab7e27536448a7624bb632332c9d0aae4",
    "support"
   ],
   "resource-timing/resources/blank_page_green.htm": [
    "2d6d55d85e17a9fe978db6dbe25ae35a599d5683",
--- a/testing/web-platform/tests/resource-timing/resources/TAOResponse.py
+++ b/testing/web-platform/tests/resource-timing/resources/TAOResponse.py
@@ -15,24 +15,24 @@ def main(request, response):
         response.headers.set('Timing-Allow-Origin', 'null')
     elif tao == 'origin':
     # case-sensitive match for origin, pass
         response.headers.set('Timing-Allow-Origin', origin)
     elif tao == 'space':
     # space seperated list of origin and wildcard, fail
         response.headers.set('Timing-Allow-Origin', (origin + ' *'))
     elif tao == 'multi':
-    # more than one TAO values, seperated by common, pass
+    # more than one TAO values, seperated by comma, pass
         response.headers.set('Timing-Allow-Origin', origin)
         response.headers.append('Timing-Allow-Origin', '*')
     elif tao == 'match_origin':
-    # contains a match of origin, seperated by common, pass
+    # contains a match of origin, seperated by comma, pass
         response.headers.set('Timing-Allow-Origin', origin)
         response.headers.append('Timing-Allow-Origin', "fake")
     elif tao == 'match_wildcard':
-    # contains a wildcard, seperated by common, pass
+    # contains a wildcard, seperated by comma, pass
         response.headers.set('Timing-Allow-Origin', "fake")
         response.headers.append('Timing-Allow-Origin', '*')
     elif tao == 'uppercase':
     # non-case-sensitive match for origin, fail
         response.headers.set('Timing-Allow-Origin', origin.upper())
     else:
-        pass
\ No newline at end of file
+        pass