Bug 1318096 part 7. Remove XPCOM element scroll* APIs. r=froydnj
authorBoris Zbarsky <bzbarsky@mit.edu>
Thu, 17 Nov 2016 13:49:27 -0500
changeset 323194 90d39fcf8890e18aa1d805124f68c2027a5f6227
parent 323193 0f66a6a676ef6a371460d44c0501fdc4f17c2090
child 323195 cdb9cc8de7a0fcf2d34fb2906788432a07dd95ef
push id30971
push usercbook@mozilla.com
push dateFri, 18 Nov 2016 15:51:34 +0000
treeherdermozilla-central@a103e1713a2e [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersfroydnj
bugs1318096
milestone53.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1318096 part 7. Remove XPCOM element scroll* APIs. r=froydnj
dom/base/Element.h
dom/interfaces/core/nsIDOMElement.idl
--- a/dom/base/Element.h
+++ b/dom/base/Element.h
@@ -1806,46 +1806,16 @@ NS_IMETHOD GetClientRects(nsIDOMClientRe
   *_retval = Element::GetClientRects().take();                                \
   return NS_OK;                                                               \
 }                                                                             \
 NS_IMETHOD GetBoundingClientRect(nsIDOMClientRect** _retval) final override   \
 {                                                                             \
   *_retval = Element::GetBoundingClientRect().take();                         \
   return NS_OK;                                                               \
 }                                                                             \
-NS_IMETHOD GetScrollTop(int32_t* aScrollTop) final override                   \
-{                                                                             \
-  *aScrollTop = Element::ScrollTop();                                         \
-  return NS_OK;                                                               \
-}                                                                             \
-NS_IMETHOD SetScrollTop(int32_t aScrollTop) final override                    \
-{                                                                             \
-  Element::SetScrollTop(aScrollTop);                                          \
-  return NS_OK;                                                               \
-}                                                                             \
-NS_IMETHOD GetScrollLeft(int32_t* aScrollLeft) final override                 \
-{                                                                             \
-  *aScrollLeft = Element::ScrollLeft();                                       \
-  return NS_OK;                                                               \
-}                                                                             \
-NS_IMETHOD SetScrollLeft(int32_t aScrollLeft) final override                  \
-{                                                                             \
-  Element::SetScrollLeft(aScrollLeft);                                        \
-  return NS_OK;                                                               \
-}                                                                             \
-NS_IMETHOD GetScrollWidth(int32_t* aScrollWidth) final override               \
-{                                                                             \
-  *aScrollWidth = Element::ScrollWidth();                                     \
-  return NS_OK;                                                               \
-}                                                                             \
-NS_IMETHOD GetScrollHeight(int32_t* aScrollHeight) final override             \
-{                                                                             \
-  *aScrollHeight = Element::ScrollHeight();                                   \
-  return NS_OK;                                                               \
-}                                                                             \
 NS_IMETHOD GetClientTop(int32_t* aClientTop) final override                   \
 {                                                                             \
   *aClientTop = Element::ClientTop();                                         \
   return NS_OK;                                                               \
 }                                                                             \
 NS_IMETHOD GetClientLeft(int32_t* aClientLeft) final override                 \
 {                                                                             \
   *aClientLeft = Element::ClientLeft();                                       \
@@ -1855,20 +1825,10 @@ NS_IMETHOD GetClientWidth(int32_t* aClie
 {                                                                             \
   *aClientWidth = Element::ClientWidth();                                     \
   return NS_OK;                                                               \
 }                                                                             \
 NS_IMETHOD GetClientHeight(int32_t* aClientHeight) final override             \
 {                                                                             \
   *aClientHeight = Element::ClientHeight();                                   \
   return NS_OK;                                                               \
-}                                                                             \
-NS_IMETHOD GetScrollLeftMax(int32_t* aScrollLeftMax) final override           \
-{                                                                             \
-  *aScrollLeftMax = Element::ScrollLeftMax();                                 \
-  return NS_OK;                                                               \
-}                                                                             \
-NS_IMETHOD GetScrollTopMax(int32_t* aScrollTopMax) final override             \
-{                                                                             \
-  *aScrollTopMax = Element::ScrollTopMax();                                   \
-  return NS_OK;                                                               \
 }
 #endif // mozilla_dom_Element_h__
--- a/dom/interfaces/core/nsIDOMElement.idl
+++ b/dom/interfaces/core/nsIDOMElement.idl
@@ -115,42 +115,16 @@ interface nsIDOMElement : nsIDOMNode
    * Returns the union of all rectangles in the getClientRects() list. Empty
    * rectangles are ignored, except that if all rectangles are empty,
    * we return an empty rectangle positioned at the top-left of the first
    * rectangle in getClientRects().
    */
   nsIDOMClientRect getBoundingClientRect();
 
   /**
-   * The vertical scroll position of the element, or 0 if the element is not
-   * scrollable. This property may be assigned a value to change the
-   * vertical scroll position.
-   */
-  attribute long             scrollTop;
-
-  /**
-   * The horizontal scroll position of the element, or 0 if the element is not
-   * scrollable. This property may be assigned a value to change the
-   * horizontal scroll position.
-   */
-  attribute long             scrollLeft;
-
-  /**
-   * The width of the scrollable area of the element. If the element is not
-   * scrollable, scrollWidth is equivalent to the offsetWidth.
-   */
-  readonly attribute long             scrollWidth;
-
-  /**
-   * The height of the scrollable area of the element. If the element is not
-   * scrollable, scrollHeight is equivalent to the offsetHeight.
-   */
-  readonly attribute long             scrollHeight;
-
-  /**
    * The height in CSS pixels of the element's top border.
    */
   readonly attribute long             clientTop;
 
   /**
    * The width in CSS pixels of the element's left border and scrollbar
    * if it is present on the left side.
    */
@@ -162,15 +136,9 @@ interface nsIDOMElement : nsIDOMNode
    */
   readonly attribute long             clientWidth;
 
   /**
    * The width in CSS pixels of the element's padding box. If the element is
    * scrollable, the scroll bars are included inside this height.
    */
   readonly attribute long             clientHeight;
-
-  /* The maximum offset that the element can be scrolled to
-     (i.e., the value that scrollLeft/scrollTop would be clamped to if they were
-     set to arbitrarily large values. */
-  readonly attribute long             scrollLeftMax;
-  readonly attribute long             scrollTopMax;
 };