Bug 1480558 - part 3 - unset AS_DASH_C_FLAG for aarch64 windows; r=mshal
authorNathan Froyd <froydnj@mozilla.com>
Tue, 21 Aug 2018 11:00:35 -0400
changeset 432605 90a93173d2474aab0374c02c3af23f5110e4e456
parent 432604 7378a8999aea1cc98e5255ebf655bfa088bf0ef5
child 432606 8eac225243d8e0846f39c0fc1e4d831765ff6991
push id34482
push usertoros@mozilla.com
push dateTue, 21 Aug 2018 21:56:56 +0000
treeherdermozilla-central@7c96ad3ab673 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmshal
bugs1480558
milestone63.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1480558 - part 3 - unset AS_DASH_C_FLAG for aarch64 windows; r=mshal The assembler for this platform doesn't need the special handling AS_DASH_C_FLAG provides.
old-configure.in
--- a/old-configure.in
+++ b/old-configure.in
@@ -859,16 +859,20 @@ case "$target" in
             # Silence problematic clang warnings
             CXXFLAGS="$CXXFLAGS -Wno-incompatible-ms-struct"
         fi
     else
         TARGET_COMPILER_ABI=msvc
         if test "$AS_BIN"; then
             AS="$(basename "$AS_BIN")"
         fi
+        # armasm64 doesn't understand -c.
+        if test "$CPU_ARCH" = "aarch64"; then
+            AS_DASH_C_FLAG=
+        fi
         case "$LINKER" in
         *lld*)
             AR='llvm-lib'
             AR_FLAGS='-llvmlibthin -out:$@'
             ;;
         *)
             AR='lib'
             AR_FLAGS='-NOLOGO -OUT:$@'