Bug 1524130 - Remove deprecation of attr modified event. r=smaug
authorXidorn Quan <me@upsuper.org>
Thu, 07 Feb 2019 14:21:08 +0000
changeset 457618 904d06bacb8f5a5593165fd10bfca302a4059db4
parent 457617 661ca61b94132d24d8f8c699334b3bcf1afcf489
child 457619 7e88e78b389830b2d335b5f5be83bb446a9c2d7c
push id35516
push userrmaries@mozilla.com
push dateFri, 08 Feb 2019 04:23:26 +0000
treeherdermozilla-central@d599d1a73a3a [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerssmaug
bugs1524130, 1461696, 1460295
milestone67.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1524130 - Remove deprecation of attr modified event. r=smaug It was added in bug 1461696 probably for tracking whether bug 1460295 is a wide-spread issue or so. This deprecation was already part of deprecated mutation event, so it's never output to console. It was added purely for getting telemetry. Given that related issues are now fixed, we no longer needs this. Differential Revision: https://phabricator.services.mozilla.com/D18935
dom/base/nsDeprecatedOperationList.h
dom/events/EventListenerManager.cpp
--- a/dom/base/nsDeprecatedOperationList.h
+++ b/dom/base/nsDeprecatedOperationList.h
@@ -35,17 +35,16 @@ DEPRECATED_OPERATION(ImageBitmapRenderin
 DEPRECATED_OPERATION(WindowContentUntrusted)
 DEPRECATED_OPERATION(RegisterProtocolHandlerInsecure)
 DEPRECATED_OPERATION(MixedDisplayObjectSubrequest)
 DEPRECATED_OPERATION(MotionEvent)
 DEPRECATED_OPERATION(OrientationEvent)
 DEPRECATED_OPERATION(ProximityEvent)
 DEPRECATED_OPERATION(AmbientLightEvent)
 DEPRECATED_OPERATION(IDBOpenDBOptions_StorageType)
-DEPRECATED_OPERATION(DOMAttrModifiedEvent)
 DEPRECATED_OPERATION(MozBoxOrInlineBoxDisplay)
 DEPRECATED_OPERATION(DOMQuadBoundsAttr)
 DEPRECATED_OPERATION(DeprecatedTestingInterface)
 DEPRECATED_OPERATION(DeprecatedTestingMethod)
 DEPRECATED_OPERATION(DeprecatedTestingAttribute)
 DEPRECATED_OPERATION(CreateImageBitmapCanvasRenderingContext2D)
 DEPRECATED_OPERATION(MozRequestFullScreenDeprecatedPrefix)
 DEPRECATED_OPERATION(MozfullscreenchangeDeprecatedPrefix)
--- a/dom/events/EventListenerManager.cpp
+++ b/dom/events/EventListenerManager.cpp
@@ -282,19 +282,16 @@ void EventListenerManager::AddEventListe
     // For mutation listeners, we need to update the global bit on the DOM
     // window. Otherwise we won't actually fire the mutation event.
     mMayHaveMutationListeners = true;
     // Go from our target to the nearest enclosing DOM window.
     if (nsPIDOMWindowInner* window = GetInnerWindowForTarget()) {
       nsCOMPtr<Document> doc = window->GetExtantDoc();
       if (doc) {
         doc->WarnOnceAbout(Document::eMutationEvent);
-        if (aEventMessage == eLegacyAttrModified) {
-          doc->WarnOnceAbout(Document::eDOMAttrModifiedEvent);
-        }
       }
       // If aEventMessage is eLegacySubtreeModified, we need to listen all
       // mutations. nsContentUtils::HasMutationListeners relies on this.
       window->SetMutationListeners(
           (aEventMessage == eLegacySubtreeModified)
               ? kAllMutationBits
               : MutationBitForEventType(aEventMessage));
     }