Bug 1509360 [wpt PR 14190] - Worker: Add [Replaceable] to SharedWorkerGlobalScope.name, a=testonly
authorHiroki Nakagawa <nhiroki@chromium.org>
Fri, 30 Nov 2018 16:53:11 +0000
changeset 449970 902c56e2f192bfc3f453b1e190a1072b9eb9bc70
parent 449969 b1aaf70feed8bb67ceb8a8af7282a3f382b1881a
child 449971 346e8c9344364d4e34a264f2319e3197e3f88285
push id35189
push userccoroiu@mozilla.com
push dateTue, 11 Dec 2018 21:33:05 +0000
treeherdermozilla-central@ac7f3beb6333 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerstestonly
bugs1509360, 14190, 875714, 1347962, 610383
milestone66.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1509360 [wpt PR 14190] - Worker: Add [Replaceable] to SharedWorkerGlobalScope.name, a=testonly Automatic update from web-platform-testsWorker: Add [Replaceable] to SharedWorkerGlobalScope.name The HTML spec requires SharedWorkerGlobalScope.name has [Replaceable]: https://html.spec.whatwg.org/multipage/workers.html#shared-workers-and-the-sharedworkerglobalscope-interface This CL also fixes a test expectation of wpt/workers/interfaces/SharedWorkerGlobalScope/name/setting.html. The name attribute is now replaceable, so the result should be replaced. Firefox fails the test because of this wrong expectation: https://wpt.fyi/results/workers/interfaces/SharedWorkerGlobalScope/name/setting.html?label=stable&aligned&q=%2Fname%2Fsetting.html Bug: 875714 Change-Id: Id04ae30895a2de4a07e30f49dc1189bb9742f6b9 Reviewed-on: https://chromium-review.googlesource.com/c/1347962 Reviewed-by: Kent Tamura <tkent@chromium.org> Reviewed-by: Matt Falkenhagen <falken@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#610383} -- wpt-commits: 76781be440f9f54acd0c8edc48dc423d727b4bba wpt-pr: 14190
testing/web-platform/tests/workers/interfaces/SharedWorkerGlobalScope/name/setting.html
testing/web-platform/tests/workers/support/name.js
--- a/testing/web-platform/tests/workers/interfaces/SharedWorkerGlobalScope/name/setting.html
+++ b/testing/web-platform/tests/workers/interfaces/SharedWorkerGlobalScope/name/setting.html
@@ -9,17 +9,17 @@ addEventListener('connect', function(e) 
 <title>setting name</title>
 <script src="/resources/testharness.js"></script>
 <script src="/resources/testharnessreport.js"></script>
 <div id="log"></div>
 <script>
 async_test(function() {
   var w1 = new SharedWorker('#1', 'x');
   w1.port.addEventListener('message', this.step_func(function(e) {
-    assert_equals(e.data, 'x');
+    assert_equals(e.data, 1);
     this.done();
   }), false);
   w1.port.start();
 });
 </script>
 <!--
 */
 //-->
--- a/testing/web-platform/tests/workers/support/name.js
+++ b/testing/web-platform/tests/workers/support/name.js
@@ -1,14 +1,14 @@
 "use strict";
 importScripts("/resources/testharness.js");
 
 test(() => {
-  assert_true(self.hasOwnProperty("name"), "property exists on the global")
-  assert_equals(self.name, "my name")
+  assert_true(self.hasOwnProperty("name"), "property exists on the global");
+  assert_equals(self.name, "my name");
 }, `name property value for ${self.constructor.name}`);
 
 test(() => {
   self.name = "something new";
   const propDesc = Object.getOwnPropertyDescriptor(self, "name");
   assert_equals(propDesc.value, "something new", "value");
   assert_true(propDesc.configurable, "configurable");
   assert_true(propDesc.writable, "writable");