Bug 415297: Content styles should control display behaviours, not the theme. r=robstrong
authorDave Townsend <dtownsend@oxymoronical.com>
Tue, 12 May 2009 09:21:15 +0100
changeset 28224 8fc05484508051a86afdc3bcbb1935a0aa0c59c8
parent 28223 61b4f75f175a003da10a171ed85dda1e778cdb99
child 28225 c61c8e18dba6153105959c17a1f766675acd1ce4
push id6954
push userdtownsend@mozilla.com
push dateTue, 12 May 2009 08:23:10 +0000
treeherdermozilla-central@c61c8e18dba6 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersrobstrong
bugs415297
milestone1.9.2a1pre
Bug 415297: Content styles should control display behaviours, not the theme. r=robstrong
toolkit/mozapps/extensions/content/extensions.css
toolkit/themes/gnomestripe/mozapps/extensions/extensions.css
toolkit/themes/pinstripe/mozapps/extensions/extensions.css
toolkit/themes/winstripe/mozapps/extensions/extensions.css
--- a/toolkit/mozapps/extensions/content/extensions.css
+++ b/toolkit/mozapps/extensions/content/extensions.css
@@ -201,36 +201,61 @@ richlistitem[action] .addonInstallButton
   display: none;
 }
 
 .searchResultInstalling, .searchResultFailed,
 .searchResultInstalled, .searchResultConnecting {
   display: none;
 }
 
-richlistitem[action="connecting"] .searchResultConnecting {
-  display: -moz-box;
-}
-
-richlistitem[action="installing"] .searchResultInstalling {
-  display: -moz-box;
-}
-
+richlistitem[action="connecting"] .searchResultConnecting,
+richlistitem[action="installing"] .searchResultInstalling,
 richlistitem[action="failed"] .searchResultFailed,
-richlistitem[action="failed"] .addonInstallButton {
-  display: -moz-box;
-}
-
+richlistitem[action="failed"] .addonInstallButton,
 richlistitem[action="installed"] .searchResultInstalled {
   display: -moz-box;
 }
 
 richlistitem .addonType {
   display: none;
 }
 
 richlistitem[addonType="2"] .addonTypeExtension {
   display: -moz-box;
 }
 
 richlistitem[addonType="4"] .addonTypeTheme {
   display: -moz-box;
 }
+
+.updateBadge,
+.updateAvailableBox,
+.notifyBadge {
+  display: none;
+}
+
+richlistitem[availableUpdateURL][updateable="true"] .updateBadge,
+richlistitem[availableUpdateURL][updateable="true"] .updateAvailableBox,
+richlistitem[compatible="false"] .notifyBadge,
+richlistitem[providesUpdatesSecurely="false"] .notifyBadge,
+richlistitem[blocklisted="true"] .notifyBadge,
+richlistitem[blocklistedsoft="true"] .notifyBadge,
+richlistitem[satisfiesDependencies="false"] .notifyBadge,
+richlistitem[loading="true"] .updateBadge {
+  display: -moz-box;
+}
+
+/* Selected Add-on status messages and images */
+richlistitem[compatible="true"] .incompatibleBox,
+richlistitem[providesUpdatesSecurely="true"] .insecureUpdateBox,
+richlistitem[satisfiesDependencies="true"] .needsDependenciesBox,
+richlistitem:not([blocklisted="true"]):not([blocklistedsoft="true"]) .blocklistedBox,
+richlistitem[blocklistedsoft="false"]:not([selected="true"]) .blocklistedBox,
+richlistitem[blocklisted="false"] .blocklistedLabel,
+richlistitem[blocklistedsoft="false"] .softBlocklistedLabel,
+richlistitem[opType="needs-uninstall"] .blocklistedBox,
+richlistitem[opType="needs-uninstall"] .incompatibleBox,
+richlistitem[opType="needs-uninstall"] .needsDependenciesBox,
+richlistitem[opType="needs-uninstall"] .notifyBadge,
+richlistitem[selected="true"]:not([opType]) .descriptionCrop,
+.addonRating:not([rating]) {
+  display: none;
+}
--- a/toolkit/themes/gnomestripe/mozapps/extensions/extensions.css
+++ b/toolkit/themes/gnomestripe/mozapps/extensions/extensions.css
@@ -86,20 +86,16 @@ richlistitem[selected="true"] .text-link
 #extensionsView:focus > richlistitem[selected="true"][isDisabled="true"] {
   background-image: url("chrome://mozapps/skin/extensions/itemDisabledFader.png");
 }
 
 .descriptionWrap {
   margin-bottom: 2px;
 }
 
-richlistitem[selected="true"]:not([opType]) .descriptionCrop {
-  display: none;
-}
-
 .addonName {
   font-weight: bold;
 }
 
 .previewText {
   font-size: larger;
   font-weight: bold;
   color: ThreeDShadow;
@@ -150,32 +146,16 @@ richlistitem[selected="true"]:not([opTyp
   list-style-image: url("chrome://mozapps/skin/extensions/notifyBadges.png");
 }
 
 .notifyBadge {
   -moz-margin-start: -2px;
   list-style-image: url("moz-icon://stock/gtk-dialog-error?size=menu");
 }
 
-.updateBadge,
-.updateAvailableBox,
-.notifyBadge {
-  display: none;
-}
-
-richlistitem[availableUpdateURL][updateable="true"] .updateBadge,
-richlistitem[availableUpdateURL][updateable="true"] .updateAvailableBox,
-richlistitem[compatible="false"] .notifyBadge,
-richlistitem[providesUpdatesSecurely="false"] .notifyBadge,
-richlistitem[blocklisted="true"] .notifyBadge,
-richlistitem[blocklistedsoft="true"] .notifyBadge,
-richlistitem[satisfiesDependencies="false"] .notifyBadge {
-  display: -moz-box;
-}
-
 /* Selected Add-on buttons
    See content/extensions.css to hide / display buttons */
 .selectedButtons {
   margin-top: 4px;
   min-height: 2.1em;
 }
 
 .selectedButtons > button {
@@ -190,33 +170,17 @@ richlistitem[satisfiesDependencies="fals
   -moz-margin-end: 0;
 }
 
 .enableButton, .disableButton,
 .uninstallButton, .cancelUninstallButton {
   -moz-margin-start: 5px;
 }
 
-/* Selected Add-on status messages and images */
-richlistitem[compatible="true"] .incompatibleBox,
-richlistitem[providesUpdatesSecurely="true"] .insecureUpdateBox,
-richlistitem[satisfiesDependencies="true"] .needsDependenciesBox,
-richlistitem:not([blocklisted="true"]):not([blocklistedsoft="true"]) .blocklistedBox,
-richlistitem[blocklistedsoft="false"]:not([selected="true"]) .blocklistedBox,
-richlistitem[blocklisted="false"] .blocklistedLabel,
-richlistitem[blocklistedsoft="false"] .softBlocklistedLabel,
-richlistitem[opType="needs-uninstall"] .blocklistedBox,
-richlistitem[opType="needs-uninstall"] .incompatibleBox,
-richlistitem[opType="needs-uninstall"] .needsDependenciesBox,
-richlistitem[opType="needs-uninstall"] .blocklistedBox {
-  display: none;
-}
-
 richlistitem[loading="true"] .updateBadge {
-  display: -moz-box;
   width: 16px;
   height: 16px;
   margin-bottom: -3px;
   -moz-margin-end: -2px;
   list-style-image: url("chrome://global/skin/icons/loading_16.png");
   -moz-image-region: auto;
 }
 
@@ -236,20 +200,16 @@ richlistitem[loading="true"] .updateBadg
   font-weight: bold;
 }
 
 .selectedStatusMsgs label.text-link {
   font-weight: normal;
   border: none;
 }
 
-richlistitem[opType="needs-uninstall"] .notifyBadge {
-  display: none;
-}
-
 .addon-search-details {
   margin-top: 5px;
   margin-bottom: 5px;
   -moz-margin-start: 6px;
   -moz-margin-end: 0;
 }
 
 .addonThumbnailContainer {
@@ -268,27 +228,22 @@ richlistitem[opType="needs-uninstall"] .
 }
 
 .addonFailure {
   width: 16px;
   height: 16px;
   list-style-image: url("moz-icon://stock/gtk-dialog-error?size=menu");
 }
 
-.addonRating {
-  display: none;
-}
-
 .addonLearnMore {
   margin-top: 4px;
   margin-bottom: 4px;
 }
 
 .addonRating[rating] {
-  display: -moz-box;
   width: 70px;
   height: 14px;
   list-style-image: url("chrome://mozapps/skin/extensions/ratings.png");
 }
 
 .addonRating[rating="0"] {
   -moz-image-region: rect(0px 70px 14px 0px);
 }
--- a/toolkit/themes/pinstripe/mozapps/extensions/extensions.css
+++ b/toolkit/themes/pinstripe/mozapps/extensions/extensions.css
@@ -81,20 +81,16 @@ richlistitem[selected="true"][isDisabled
 .descriptionWrap {
   margin-bottom: 2px;
 }
 
 richlistitem:not([selected="true"]) .addon-description {
   color: #707070;
 }
 
-richlistitem[selected="true"]:not([opType]) .descriptionCrop {
-  display: none;
-}
-
 .addon-name-version {
   font-size: 110%;
 }
 
 .previewText {
   font-size: larger;
   font-weight: bold;
   color: ThreeDShadow;
@@ -147,32 +143,16 @@ richlistitem[selected="true"]:not([opTyp
   -moz-image-region: rect(0px 16px 16px 0px);
 }
 
 .notifyBadge {
   -moz-margin-start: -2px;
   -moz-image-region: rect(0px 48px 16px 32px);
 }
 
-.updateBadge,
-.updateAvailableBox,
-.notifyBadge {
-  display: none;
-}
-
-richlistitem[availableUpdateURL][updateable="true"] .updateBadge,
-richlistitem[availableUpdateURL][updateable="true"] .updateAvailableBox,
-richlistitem[compatible="false"] .notifyBadge,
-richlistitem[providesUpdatesSecurely="false"] .notifyBadge,
-richlistitem[blocklisted="true"] .notifyBadge,
-richlistitem[blocklistedsoft="true"] .notifyBadge,
-richlistitem[satisfiesDependencies="false"] .notifyBadge {
-  display: -moz-box;
-}
-
 /* Selected Add-on buttons
    See content/extensions.css to hide / display buttons */
 .selectedButtons {
   margin-top: 4px;
 }
 
 .selectedButtons > button {
   margin-top: 0;
@@ -188,33 +168,17 @@ richlistitem[satisfiesDependencies="fals
   -moz-margin-end: 0;
 }
 
 .enableButton, .disableButton,
 .uninstallButton, .cancelUninstallButton {
   -moz-margin-start: 5px;
 }
 
-/* Selected Add-on status messages and images */
-richlistitem[compatible="true"] .incompatibleBox,
-richlistitem[providesUpdatesSecurely="true"] .insecureUpdateBox,
-richlistitem[satisfiesDependencies="true"] .needsDependenciesBox,
-richlistitem:not([blocklisted="true"]):not([blocklistedsoft="true"]) .blocklistedBox,
-richlistitem[blocklistedsoft="false"]:not([selected="true"]) .blocklistedBox,
-richlistitem[blocklisted="false"] .blocklistedLabel,
-richlistitem[blocklistedsoft="false"] .softBlocklistedLabel,
-richlistitem[opType="needs-uninstall"] .blocklistedBox,
-richlistitem[opType="needs-uninstall"] .incompatibleBox,
-richlistitem[opType="needs-uninstall"] .needsDependenciesBox,
-richlistitem[opType="needs-uninstall"] .blocklistedBox {
-  display: none;
-}
-
 richlistitem[loading="true"] .updateBadge {
-  display: -moz-box;
   width: 16px;
   height: 16px;
   margin-bottom: -3px;
   -moz-margin-end: -2px;
   list-style-image: url("chrome://global/skin/icons/loading_16.png");
   -moz-image-region: auto;
 }
 
@@ -238,20 +202,16 @@ richlistitem[loading="true"] .updateBadg
   font-weight: normal;
   border: none;
 }
 
 .attention {
   -moz-box-pack: end;
 }
 
-richlistitem[opType="needs-uninstall"] .notifyBadge {
-  display: none;
-}
-
 .addon-search-details {
   margin-top: 5px;
   margin-bottom: 5px;
   -moz-margin-start: 6px;
   -moz-margin-end: 0;
 }
 
 .addonThumbnailContainer {
@@ -271,27 +231,22 @@ richlistitem[opType="needs-uninstall"] .
 
 .addonFailure {
   width: 16px;
   height: 16px;
   list-style-image: url("chrome://mozapps/skin/extensions/notifyBadges.png");
   -moz-image-region: rect(0px 48px 16px 32px);
 }
 
-.addonRating {
-  display: none;
-}
-
 .addonLearnMore {
   margin-top: 4px;
   margin-bottom: 4px;
 }
 
 .addonRating[rating] {
-  display: -moz-box;
   width: 78px;
   height: 18px;
   list-style-image: url("chrome://mozapps/skin/extensions/ratings.png");
 }
 
 .addonRating[rating="0"] {
   -moz-image-region: rect(0px 78px 18px 0px);
 }
--- a/toolkit/themes/winstripe/mozapps/extensions/extensions.css
+++ b/toolkit/themes/winstripe/mozapps/extensions/extensions.css
@@ -76,20 +76,16 @@ richlistitem[selected="true"] .text-link
 #extensionsView:focus > richlistitem[selected="true"][isDisabled="true"] {
   background-image: url("chrome://mozapps/skin/extensions/itemDisabledFader.png");
 }
 
 .descriptionWrap {
   margin-bottom: 2px;
 }
 
-richlistitem[selected="true"]:not([opType]) .descriptionCrop {
-  display: none;
-}
-
 .addonName {
   font-weight: bold;
 }
 
 .previewText {
   font-size: larger;
   font-weight: bold;
   color: ThreeDShadow;
@@ -141,32 +137,16 @@ richlistitem[selected="true"]:not([opTyp
   -moz-image-region: rect(0px 16px 16px 0px);
 }
 
 .notifyBadge {
   -moz-margin-start: -2px;
   -moz-image-region: rect(0px 48px 16px 32px);
 }
 
-.updateBadge,
-.updateAvailableBox,
-.notifyBadge {
-  display: none;
-}
-
-richlistitem[availableUpdateURL][updateable="true"] .updateBadge,
-richlistitem[availableUpdateURL][updateable="true"] .updateAvailableBox,
-richlistitem[compatible="false"] .notifyBadge,
-richlistitem[providesUpdatesSecurely="false"] .notifyBadge,
-richlistitem[blocklisted="true"] .notifyBadge,
-richlistitem[blocklistedsoft="true"] .notifyBadge,
-richlistitem[satisfiesDependencies="false"] .notifyBadge {
-  display: -moz-box;
-}
-
 /* Selected Add-on buttons
    See content/extensions.css to hide / display buttons */
 .selectedButtons {
   margin-top: 4px;
   min-height: 2.1em;
 }
 
 .selectedButtons > button {
@@ -181,33 +161,17 @@ richlistitem[satisfiesDependencies="fals
   -moz-margin-end: 0;
 }
 
 .enableButton, .disableButton,
 .uninstallButton, .cancelUninstallButton {
   -moz-margin-start: 5px;
 }
 
-/* Selected Add-on status messages and images */
-richlistitem[compatible="true"] .incompatibleBox,
-richlistitem[providesUpdatesSecurely="true"] .insecureUpdateBox,
-richlistitem[satisfiesDependencies="true"] .needsDependenciesBox,
-richlistitem:not([blocklisted="true"]):not([blocklistedsoft="true"]) .blocklistedBox,
-richlistitem[blocklistedsoft="false"]:not([selected="true"]) .blocklistedBox,
-richlistitem[blocklisted="false"] .blocklistedLabel,
-richlistitem[blocklistedsoft="false"] .softBlocklistedLabel,
-richlistitem[opType="needs-uninstall"] .blocklistedBox,
-richlistitem[opType="needs-uninstall"] .incompatibleBox,
-richlistitem[opType="needs-uninstall"] .needsDependenciesBox,
-richlistitem[opType="needs-uninstall"] .blocklistedBox {
-  display: none;
-}
-
 richlistitem[loading="true"] .updateBadge {
-  display: -moz-box;
   width: 16px;
   height: 16px;
   margin-bottom: -3px;
   -moz-margin-end: -2px;
   list-style-image: url("chrome://global/skin/icons/loading_16.png");
   -moz-image-region: auto;
 }
 
@@ -227,20 +191,16 @@ richlistitem[loading="true"] .updateBadg
   font-weight: bold;
 }
 
 .selectedStatusMsgs label.text-link {
   font-weight: normal;
   border: none;
 }
 
-richlistitem[opType="needs-uninstall"] .notifyBadge {
-  display: none;
-}
-
 .addon-search-details {
   margin-top: 5px;
   margin-bottom: 5px;
   -moz-margin-start: 6px;
   -moz-margin-end: 0;
 }
 
 .addonThumbnailContainer {
@@ -260,27 +220,22 @@ richlistitem[opType="needs-uninstall"] .
 
 .addonFailure {
   width: 16px;
   height: 16px;
   list-style-image: url("chrome://mozapps/skin/extensions/notifyBadges.png");
   -moz-image-region: rect(0px 48px 16px 32px);
 }
 
-.addonRating {
-  display: none;
-}
-
 .addonLearnMore {
   margin-top: 4px;
   margin-bottom: 4px;
 }
 
 .addonRating[rating] {
-  display: -moz-box;
   width: 59px;
   height: 11px;
   list-style-image: url("chrome://mozapps/skin/extensions/ratings.png");
 }
 
 .addonRating[rating="0"] {
   -moz-image-region: rect(0px 59px 11px 0px);
 }