Bug 836149: declare pseudoStackPos as uint32_t instead of int in TableTicker.cpp, to fix signed/unsigned comparison build warning. r=BenWa
authorDaniel Holbert <dholbert@cs.stanford.edu>
Tue, 29 Jan 2013 18:51:43 -0800
changeset 120324 8ef47aa7120f2202fc80c9004d7fcab95ef3c9a3
parent 120323 7d45649de683d8ff3c27580d7856c5e1c92b22af
child 120325 ec05a370f01d46722b1589d55223dd44d3eccb07
push id24246
push userryanvm@gmail.com
push dateWed, 30 Jan 2013 13:05:37 +0000
treeherdermozilla-central@5f9775715519 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersBenWa
bugs836149
milestone21.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 836149: declare pseudoStackPos as uint32_t instead of int in TableTicker.cpp, to fix signed/unsigned comparison build warning. r=BenWa
tools/profiler/TableTicker.cpp
--- a/tools/profiler/TableTicker.cpp
+++ b/tools/profiler/TableTicker.cpp
@@ -839,17 +839,17 @@ void TableTicker::doBacktrace(ThreadProf
 
   nsresult rv = NS_StackWalk(StackWalkCallback, /* skipFrames */ 0, maxFrames,
                              &array, thread, platformData);
 #endif
   if (NS_SUCCEEDED(rv)) {
     aProfile.addTag(ProfileEntry('s', "(root)"));
 
     ProfileStack* stack = aProfile.GetStack();
-    int pseudoStackPos = 0;
+    uint32_t pseudoStackPos = 0;
 
     /* We have two stacks, the native C stack we extracted from unwinding,
      * and the pseudostack we managed during execution. We want to consolidate
      * the two in order. We do so by merging using the approximate stack address
      * when each entry was push. When pushing JS entry we may not now the stack
      * address in which case we have a NULL stack address in which case we assume
      * that it follows immediatly the previous element.
      *