Bug 1582303 - Fix formatting in Scopes panel for array items with watchpoints. r=jlast
authorMiriam <bmiriam1230@gmail.com>
Mon, 07 Oct 2019 20:40:32 +0000
changeset 496662 8eda685183b140821a29269542d4617c455bad18
parent 496661 402db246b36ea3db0b784e7db75e68d63bddfb07
child 496663 4c696f6996de4681b114a6cf17f4b750d5363f68
push id36664
push userccoroiu@mozilla.com
push dateTue, 08 Oct 2019 04:15:42 +0000
treeherdermozilla-central@7c3489dfee60 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjlast
bugs1582303
milestone71.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1582303 - Fix formatting in Scopes panel for array items with watchpoints. r=jlast Differential Revision: https://phabricator.services.mozilla.com/D48083
devtools/server/actors/object.js
--- a/devtools/server/actors/object.js
+++ b/devtools/server/actors/object.js
@@ -788,17 +788,18 @@ const proto = {
     const retval = {
       configurable: desc.configurable,
       enumerable: desc.enumerable,
     };
 
     if ("value" in desc) {
       retval.writable = desc.writable;
       retval.value = this.hooks.createValueGrip(desc.value);
-    } else if (this._originalDescriptors.has(name)) {
+    } else if (this._originalDescriptors.has(name.toString())) {
+      name = name.toString();
       const watchpointType = this._originalDescriptors.get(name).watchpointType;
       desc = this._originalDescriptors.get(name).desc;
       retval.value = this.hooks.createValueGrip(
         this.obj.makeDebuggeeValue(desc.value)
       );
       retval.watchpoint = watchpointType;
     } else {
       if ("get" in desc) {