Bug 1496486 - Valgrind suppression. rs=froydnj
authorEmilio Cobos Álvarez <emilio@crisal.io>
Tue, 09 Oct 2018 18:58:48 +0200
changeset 440292 8ecaee03d38e25edbdebaa8276a9140c24a57c46
parent 440291 836472045b3b69d18d219f12b7319d53e39f0ddd
child 440293 f8a20bd8689532d06434a57551e346a6733dbba0
push id34812
push userrgurzau@mozilla.com
push dateTue, 09 Oct 2018 21:59:49 +0000
treeherdermozilla-central@4845f02cf354 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersfroydnj
bugs1496486
milestone64.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1496486 - Valgrind suppression. rs=froydnj I rewrote the computed value implementation to avoid allocating and this tricked Valgrind. There's nothing uninitialized or unsafe from the code in: https://hg.mozilla.org/integration/autoland/rev/4dd15fa31474#l28.68
build/valgrind/x86_64-pc-linux-gnu.sup
--- a/build/valgrind/x86_64-pc-linux-gnu.sup
+++ b/build/valgrind/x86_64-pc-linux-gnu.sup
@@ -521,16 +521,31 @@
    Bug 1479055: style::properties::longhands::clip_path::cascade_property
    Memcheck:Cond
    fun:_ZN5style10properties9longhands9clip_path16cascade_property*
    fun:_ZN5style10properties13cascade_rules*
    fun:_ZN109_$LT$style*style_resolver*cascade_style_and_visited*
    fun:_ZN109_$LT$style*cascade_primary_style*
 }
 
+# Another suppression for Stylo, October 2018.  See bug 1496486.
+# Conditional jump or move depends on uninitialised value(s)
+#    at 0x108E2931: style::properties::longhands::font_language_override::cascade_property+81 (font.rs:2095)
+#    by 0x107E95B4: style::properties::cascade::Cascade::apply_properties+580 (cascade.rs:463)
+#    by 0x107E82D8: style::properties::cascade::cascade_rules+2440 (cascade.rs:303)
+#    by 0x107E7206: <style::style_resolver::StyleResolverForElement<'a, 'ctx, 'le, E>>::cascade_style_and_visited+310 (cascade.rs:93)
+#  Uninitialised value was created by a stack allocation
+#    at 0x10A42A40: style::properties::shorthands::font::parse_value (font.rs:376)
+{
+   Bug 1496486: style::properties::longhands::font_language_override::cascade_property
+   Memcheck:Cond
+   fun:_ZN5style10properties9longhands22font_language_override16cascade_property*
+   fun:_ZN5style10properties7cascade7Cascade16apply_properties*
+   fun:_ZN5style10properties7cascade13cascade_rules*
+}
 
 ###################################################
 #  For valgrind-mochitest ("tc-M-V [tier 2]") runs on taskcluster.
 #  See bug 1248365.
 #  These are specific to Ubuntu 12.04.5, 64-bit.
 ###################################################