Backed out changeset d956ff86aaa6 (bug 1368649) for wError bustage on linux builds a=backout
authorWes Kocher <wkocher@mozilla.com>
Thu, 01 Jun 2017 18:14:02 -0700
changeset 361939 8e3f7a301dc18cf2b580f44fb8018dabd2c3c79c
parent 361938 d956ff86aaa6e2870860c11dfbfd86591392a16f
child 361940 4229107601dd76168852410c0858a5ca42519acc
push id31952
push usercbook@mozilla.com
push dateFri, 02 Jun 2017 12:17:25 +0000
treeherdermozilla-central@194c009d6295 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersbackout
bugs1368649
milestone55.0a1
backs outd956ff86aaa6e2870860c11dfbfd86591392a16f
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Backed out changeset d956ff86aaa6 (bug 1368649) for wError bustage on linux builds a=backout MozReview-Commit-ID: DObINDiBa0F
build/moz.configure/warnings.configure
old-configure.in
--- a/build/moz.configure/warnings.configure
+++ b/build/moz.configure/warnings.configure
@@ -93,18 +93,18 @@ check_and_add_gcc_warning('-Wno-error=ma
 check_and_add_gcc_warning('-Wno-error=deprecated-declarations')
 
 # false positives depending on optimization
 check_and_add_gcc_warning('-Wno-error=array-bounds')
 
 # can't get rid of those PGO warnings
 check_and_add_gcc_warning('-Wno-error=coverage-mismatch', when='MOZ_PGO')
 
-# false positives depending on optimizations
-check_and_add_gcc_warning('-Wno-error=free-nonheap-object')
+# false positives during PGO
+check_and_add_gcc_warning('-Wno-error=free-nonheap-object', when='MOZ_PGO')
 
 # catches format/argument mismatches with printf
 check_and_add_gcc_warning('-Wformat')
 
 # We use mix of both POSIX and Win32 printf format across the tree, so format
 # warnings are useless on mingw.
 check_and_add_gcc_warning('-Wno-format',
                           when=depends(target)(lambda t: t.kernel == 'WINNT'))
--- a/old-configure.in
+++ b/old-configure.in
@@ -883,17 +883,17 @@ case "$target" in
     if test -z "$CLANG_CC"; then
        MOZ_OPTIMIZE_FLAGS="-freorder-blocks -fno-reorder-functions $MOZ_OPTIMIZE_FLAGS"
     fi
     ;;
 
 *-*linux*)
     if test "$GNU_CC" -o "$GNU_CXX"; then
         MOZ_PGO_OPTIMIZE_FLAGS="-O3"
-        MOZ_OPTIMIZE_FLAGS="-O2"
+        MOZ_OPTIMIZE_FLAGS="-Os"
         if test -z "$CLANG_CC"; then
            MOZ_OPTIMIZE_FLAGS="-freorder-blocks $MOZ_OPTIMIZE_FLAGS"
         fi
     fi
 
     case "${target_cpu}" in
     alpha*)
         CFLAGS="$CFLAGS -mieee"