Bug 1614139 - Copy constructor of nsPipeInputStream should not be declared explicit. r=froydnj
authorTuan <tuan.mate@outlook.com>
Thu, 13 Feb 2020 16:09:09 +0000
changeset 513775 8e18b9d4caae67779bf1a8922fe4282e91a36b66
parent 513774 5cd44d9d7e0f581331bdc86921ee15d9fae6b8f7
child 513776 24b97b0c24f0f30965d5d30dfa2a796e3c994e5e
push id37121
push useropoprus@mozilla.com
push dateThu, 13 Feb 2020 21:42:57 +0000
treeherdermozilla-central@51dbdcd6e874 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersfroydnj
bugs1614139
milestone75.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1614139 - Copy constructor of nsPipeInputStream should not be declared explicit. r=froydnj Differential Revision: https://phabricator.services.mozilla.com/D62735
xpcom/io/nsPipe3.cpp
--- a/xpcom/io/nsPipe3.cpp
+++ b/xpcom/io/nsPipe3.cpp
@@ -151,17 +151,17 @@ class nsPipeInputStream final : public n
       : mPipe(aPipe),
         mLogicalOffset(0),
         mInputStatus(NS_OK),
         mBlocking(true),
         mBlocked(false),
         mCallbackFlags(0),
         mPriority(nsIRunnablePriority::PRIORITY_NORMAL) {}
 
-  explicit nsPipeInputStream(const nsPipeInputStream& aOther)
+  nsPipeInputStream(const nsPipeInputStream& aOther)
       : mPipe(aOther.mPipe),
         mLogicalOffset(aOther.mLogicalOffset),
         mInputStatus(aOther.mInputStatus),
         mBlocking(aOther.mBlocking),
         mBlocked(false),
         mCallbackFlags(0),
         mReadState(aOther.mReadState),
         mPriority(nsIRunnablePriority::PRIORITY_NORMAL) {}