Bug 1481631 [wpt PR 12345] - MSE: Make changeType-play layout tests' audio mime-type be audio-specific, a=testonly
authorMatt Wolenetz <wolenetz@chromium.org>
Mon, 13 Aug 2018 18:23:15 +0000
changeset 431518 8da92fbd2897d3df88b029b1d9985940717ac63b
parent 431517 07c3e8edac20aebdaba07c621751b04eb9b77743
child 431519 fad7f71861a34f74f51e6af5c13f68cc6dbe1335
push id34443
push usercsabou@mozilla.com
push dateWed, 15 Aug 2018 00:53:32 +0000
treeherdermozilla-central@b80906e2fbc9 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerstestonly
bugs1481631, 12345, 871929, 12336, 1166030, 581369
milestone63.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1481631 [wpt PR 12345] - MSE: Make changeType-play layout tests' audio mime-type be audio-specific, a=testonly Automatic update from web-platform-testsMSE: Make changeType-play layout tests' audio mime-type be audio-specific If using video/webm for an audio codec/stream, some user agents will say the type is unsupported where otherwise it would be if it were audio/<bytestream-format> for the same codec/stream. This change makes the types in audio test metadata match the stream types more closely (audio/webm;... and audio/mp4;...). This change also includes a drive-by comment addition to help ensure the audioOnlyTypes in mediasource-util.js remain correct relative to the changeType tests' assumptions that none of the audioOnlyTypes generate timestamps automatically. BUG=871929 WPT issue https://github.com/web-platform-tests/wpt/issues/12336 Change-Id: I768035b817ad46f9f17f7dc681c3f9f5c1dad8e4 Reviewed-on: https://chromium-review.googlesource.com/1166030 Reviewed-by: Dan Sanders <sandersd@chromium.org> Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Cr-Commit-Position: refs/heads/master@{#581369} -- wpt-commits: 531bf4a9a5fd6e7812a40a8df1a6c32b4ba748e3 wpt-pr: 12345
testing/web-platform/meta/MANIFEST.json
testing/web-platform/tests/media-source/mediasource-changetype-util.js
testing/web-platform/tests/media-source/mediasource-util.js
--- a/testing/web-platform/meta/MANIFEST.json
+++ b/testing/web-platform/meta/MANIFEST.json
@@ -606357,17 +606357,17 @@
    "38cd1717eb23be2d6ef9dde3959aa79b48621193",
    "testharness"
   ],
   "media-source/mediasource-changetype-play.html": [
    "c4527149d0d4b8f4b8943387a7de8872b632fd72",
    "testharness"
   ],
   "media-source/mediasource-changetype-util.js": [
-   "f6976d2238dcbb749b749e5a53e97e938a8cde3d",
+   "4e24223e0439f6c84b205ae23c21e140480c121c",
    "support"
   ],
   "media-source/mediasource-changetype.html": [
    "263dd82671650afc6d4456ed0aff2eb0ec543235",
    "testharness"
   ],
   "media-source/mediasource-closed.html": [
    "4b22cae85445d73da19de7cd145a8789cd9f562f",
@@ -606537,17 +606537,17 @@
    "5fc2e5e97d6a04783409e05fb539eb29f1c761a7",
    "testharness"
   ],
   "media-source/mediasource-trackdefaultlist.html": [
    "cceda8be460a610b03afd35e83facf544901a731",
    "testharness"
   ],
   "media-source/mediasource-util.js": [
-   "15a56e83faa78a2f9bd493841ae4fa59f813bf68",
+   "bb701e705245828143b8b8be45ebec2cffaf9c11",
    "support"
   ],
   "media-source/mp3/sound_5.mp3": [
    "bd202919899c5586a62790a11780649642447066",
    "support"
   ],
   "media-source/mp4/test-a-128k-44100Hz-1ch-manifest.json": [
    "f3caa460e9f078278680c6cdb9e1ce914a8c59ae",
--- a/testing/web-platform/tests/media-source/mediasource-changetype-util.js
+++ b/testing/web-platform/tests/media-source/mediasource-changetype-util.js
@@ -14,22 +14,22 @@ function findSupportedChangeTypeTestType
             url: 'webm/test-vp9.webm'
         },
         {
             type: 'video/mp4; codecs="avc1.4D4001"',
             is_video: true,
             url: 'mp4/test-v-128k-320x240-24fps-8kfr.mp4'
         },
         {
-            type: 'video/webm; codecs="vorbis"',
+            type: 'audio/webm; codecs="vorbis"',
             is_video: false,
             url: 'webm/test-a-128k-44100Hz-1ch.webm'
         },
         {
-            type: 'video/mp4; codecs="mp4a.40.2"',
+            type: 'audio/mp4; codecs="mp4a.40.2"',
             is_video: false,
             url: 'mp4/test-a-128k-44100Hz-1ch.mp4'
         },
         {
             type: 'audio/mpeg',
             is_video: false,
             url: 'mp3/sound_5.mp3'
         }
--- a/testing/web-platform/tests/media-source/mediasource-util.js
+++ b/testing/web-platform/tests/media-source/mediasource-util.js
@@ -217,17 +217,20 @@
             var segmentInfo = SEGMENT_INFO_LIST[i];
             if (window.MediaSource && MediaSource.isTypeSupported(segmentInfo.type)) {
                 return segmentInfo;
             }
         }
         return null;
     }
 
+    // To support mediasource-changetype tests, do not use any types that
+    // indicate automatic timestamp generation in this audioOnlyTypes list.
     var audioOnlyTypes = ['audio/mp4;codecs="mp4a.40.2"', 'audio/webm;codecs="vorbis"'];
+
     var videoOnlyTypes = ['video/mp4;codecs="avc1.4D4001"', 'video/webm;codecs="vp8"'];
     var audioVideoTypes = ['video/mp4;codecs="avc1.4D4001,mp4a.40.2"', 'video/webm;codecs="vp8,vorbis"'];
     MediaSourceUtil.AUDIO_ONLY_TYPE = getFirstSupportedType(audioOnlyTypes);
     MediaSourceUtil.VIDEO_ONLY_TYPE = getFirstSupportedType(videoOnlyTypes);
     MediaSourceUtil.AUDIO_VIDEO_TYPE = getFirstSupportedType(audioVideoTypes);
     MediaSourceUtil.SEGMENT_INFO = getSegmentInfo();
 
     MediaSourceUtil.getSubType = function(mimetype) {