Bug 1466806 - fix RTL for tree view row expanders overlay and positioning. r=Honza
authorYura Zenevich <yura.zenevich@gmail.com>
Wed, 13 Jun 2018 11:57:02 -0400
changeset 423016 8d7c028d3d536267f424a5914cb1bad345f8695f
parent 423015 5e2eaa601a6d98b5c6d892dc1a6f409145edef7e
child 423017 d5ee1692bd3cd758ad9633df67604f18b4cd1d8b
push id34162
push userapavel@mozilla.com
push dateWed, 20 Jun 2018 11:28:39 +0000
treeherdermozilla-central@681eb7dfa324 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersHonza
bugs1466806
milestone62.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1466806 - fix RTL for tree view row expanders overlay and positioning. r=Honza MozReview-Commit-ID: 8oPuRGIvMad
devtools/client/accessibility/accessibility.css
devtools/client/shared/components/tree/TreeView.css
--- a/devtools/client/accessibility/accessibility.css
+++ b/devtools/client/accessibility/accessibility.css
@@ -118,16 +118,19 @@ body {
 /* TreeView Customization */
 .split-box:not(.horz) .main-panel {
   height: calc(100vh - var(--accessibility-toolbar-height));
 }
 
 .treeTable > thead {
   position: sticky;
   top: 0;
+  /* Bug 1466806 - fix expander arrow for expanding treeview rows rendering over the
+     thead */
+  z-index: 1;
 }
 
 .split-box:not(.horz) .treeTable {
   /* To compenstate for 1px splitter between the tree and sidebar. */
   width: var(--accessibility-full-length-minus-splitter);
 }
 
 .split-box.horz .treeTable {
--- a/devtools/client/shared/components/tree/TreeView.css
+++ b/devtools/client/shared/components/tree/TreeView.css
@@ -52,16 +52,20 @@
   transition: all 0.2s ease-in-out;
 }
 
 .treeTable .treeLabelCell {
   cursor: default;
   overflow: hidden;
   padding-inline-start: 4px;
   white-space: nowrap;
+}
+
+.treeTable .treeValueCell > [aria-labelledby],
+.treeTable .treeLabelCell > .treeLabel {
   unicode-bidi: plaintext;
 }
 
 /* No padding if there is actually no label */
 .treeTable .treeLabel:empty {
   padding-inline-start: 0;
 }