Bug 602872 - remove the idle-daily workaround introduced in Places unit tests, no more needed. a=tests-only
authorMarco Bonardo <mbonardo@mozilla.com>
Tue, 19 Oct 2010 11:18:42 +0200
changeset 56081 8d53ea71793e
parent 56080 6e4fbb231f1c
child 56082 c9df0c5cbf8c
push id16398
push usermak77@bonardo.net
push date2010-10-19 09:19 +0000
treeherdermozilla-central@8d53ea71793e [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerstests-only
bugs602872
milestone2.0b8pre
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 602872 - remove the idle-daily workaround introduced in Places unit tests, no more needed. a=tests-only
toolkit/components/places/tests/head_common.js
--- a/toolkit/components/places/tests/head_common.js
+++ b/toolkit/components/places/tests/head_common.js
@@ -503,26 +503,8 @@ let (randomFailingSyncTests = [
   let currentTestFilename = do_get_file(_TEST_FILE[0], true).leafName;
   if (randomFailingSyncTests.indexOf(currentTestFilename) != -1) {
     print("Test " + currentTestFilename +
           " is known random due to bug 507790, disabling PlacesDBFlush.");
     let sync = Cc["@mozilla.org/places/sync;1"].getService(Ci.nsIObserver);
     sync.observe(null, "places-debug-stop-sync", null);
   }
 }
-
-// These tests are randomly failing if idle-daily is executed in the middle,
-// thus we make history ignore the notification for them.  See bug 602872.
-let (randomFailingIdleTests = [
-  "test_redirectsMode.js",
-  "test_tags.js",
-  "test_history_sidebar.js",
-  "test_removeVisitsByTimeframe.js",
-  "test_history_removeAllPages.js", // Needs stable frecency.
-  "test_database_sync_after_shutdown_with_removeAllPages.js", // Needs stable frecency.
-]) {
-  let currentTestFilename = do_get_file(_TEST_FILE[0], true).leafName;
-  if (randomFailingIdleTests.indexOf(currentTestFilename) != -1) {
-    print("Test " + currentTestFilename +
-          " is known random due to idle-daily, remove observer.");
-    Services.obs.removeObserver(PlacesUtils.history, "idle-daily");
-  }
-}