author | Chris Pearce <cpearce@mozilla.com> |
Tue, 01 Nov 2016 16:36:00 +1300 | |
changeset 320439 | 8d38f007c9111c5fea264ac79914d1296a2992a3 |
parent 320438 | 97147b709fd84ed5693376f14b14e8d0d452d616 |
child 320440 | 255aac711339ce9a12fb5b1c4239c1fe4c7062a7 |
push id | 30901 |
push user | kwierso@gmail.com |
push date | Thu, 03 Nov 2016 00:16:45 +0000 |
treeherder | mozilla-central@ac55a6776435 [default view] [failures only] |
perfherder | [talos] [build metrics] [platform microbench] (compared to previous push) |
reviewers | gerald |
bugs | 1312540 |
milestone | 52.0a1 |
first release with | nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
|
last release without | nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
|
--- a/dom/media/gmp/GMPServiceParent.cpp +++ b/dom/media/gmp/GMPServiceParent.cpp @@ -975,29 +975,22 @@ GeckoMediaPluginServiceParent::GetPlugin NS_WARNING("Failed to load GMPs from disk."); return rv; } { MutexAutoLock lock(mMutex); nsCString api(aAPI); size_t index = 0; - - // We must parse the version number into a float for comparison. Yuck. - double maxParsedVersion = -1.; - - *aHasPlugin = false; - while (RefPtr<GMPParent> gmp = FindPluginForAPIFrom(index, api, *aTags, &index)) { + RefPtr<GMPParent> gmp = FindPluginForAPIFrom(index, api, *aTags, &index); + if (gmp) { *aHasPlugin = true; - double parsedVersion = atof(gmp->GetVersion().get()); - if (maxParsedVersion < 0 || parsedVersion > maxParsedVersion) { - maxParsedVersion = parsedVersion; - aOutVersion = gmp->GetVersion(); - } - index++; + aOutVersion = gmp->GetVersion(); + } else { + *aHasPlugin = false; } } return NS_OK; } nsresult GeckoMediaPluginServiceParent::EnsurePluginsOnDiskScanned()