Bug 747683 - Don't unload the plugin library right before exiting the plugin process, because some plugins are using atexit handlers, r=josh
authorBenjamin Smedberg <benjamin@smedbergs.us>
Wed, 13 Jun 2012 15:03:03 -0700
changeset 96605 8cf5423b021396e96c096443431e0e0b0f0c6d69
parent 96604 880f30ecdf6bb7fcd8ea96e07adc1e461e0728bb
child 96606 b30e903d23a08a91f682048c2849408c8f20d206
push id22922
push userbsmedberg@mozilla.com
push dateWed, 13 Jun 2012 22:20:06 +0000
treeherdermozilla-central@8cf5423b0213 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjosh
bugs747683
milestone16.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 747683 - Don't unload the plugin library right before exiting the plugin process, because some plugins are using atexit handlers, r=josh
dom/plugins/ipc/PluginModuleChild.cpp
--- a/dom/plugins/ipc/PluginModuleChild.cpp
+++ b/dom/plugins/ipc/PluginModuleChild.cpp
@@ -108,19 +108,19 @@ PluginModuleChild::PluginModuleChild()
 #ifdef XP_MACOSX
     mac_plugin_interposing::child::SetUpCocoaInterposing();
 #endif
 }
 
 PluginModuleChild::~PluginModuleChild()
 {
     NS_ASSERTION(gInstance == this, "Something terribly wrong here!");
-    if (mLibrary) {
-        PR_UnloadLibrary(mLibrary);
-    }
+
+    // We don't unload the plugin library in case it uses atexit handlers or
+    // other similar hooks.
 
     DeinitGraphics();
 
     gInstance = nsnull;
 }
 
 // static
 PluginModuleChild*