Bug 1091793 - Remove MNop for AsmJS like testing code. r=jandem
authorNicolas B. Pierron <nicolas.b.pierron@mozilla.com>
Fri, 31 Oct 2014 17:16:10 +0100
changeset 213412 8cecdc9616a4e56e184ba304ba75b981cc10b8ed
parent 213411 b5a7134e728ced2c2314726e65414ddf68c90a89
child 213413 10616214c160ac2bb06e36d5ed23aea87ba9925b
push id27748
push userryanvm@gmail.com
push dateFri, 31 Oct 2014 20:14:33 +0000
treeherdermozilla-central@12ac66e2c016 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjandem
bugs1091793
milestone36.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1091793 - Remove MNop for AsmJS like testing code. r=jandem CLOSED TREE
js/src/jsapi-tests/testJitFoldsTo.cpp
js/src/jsapi-tests/testJitGVN.cpp
--- a/js/src/jsapi-tests/testJitFoldsTo.cpp
+++ b/js/src/jsapi-tests/testJitFoldsTo.cpp
@@ -137,19 +137,16 @@ BEGIN_TEST(testJitNotTest)
     // MTest(Not(p))
     MParameter *p = func.createParameter();
     block->add(p);
     MNot *not0 = MNot::New(func.alloc, p);
     block->add(not0);
     MTest *test = MTest::New(func.alloc, not0, then, else_);
     block->end(test);
 
-    MNop *anchor = MNop::New(func.alloc);
-    anchor->setGuard();
-    then->add(anchor);
     then->end(MGoto::New(func.alloc, exit));
 
     else_->end(MGoto::New(func.alloc, exit));
 
     MReturn *ret = MReturn::New(func.alloc, p);
     exit->end(ret);
 
     exit->addPredecessorWithoutPhis(then);
@@ -179,19 +176,16 @@ BEGIN_TEST(testJitNotNotTest)
     block->add(p);
     MNot *not0 = MNot::New(func.alloc, p);
     block->add(not0);
     MNot *not1 = MNot::New(func.alloc, not0);
     block->add(not1);
     MTest *test = MTest::New(func.alloc, not1, then, else_);
     block->end(test);
 
-    MNop *anchor = MNop::New(func.alloc);
-    anchor->setGuard();
-    then->add(anchor);
     then->end(MGoto::New(func.alloc, exit));
 
     else_->end(MGoto::New(func.alloc, exit));
 
     MReturn *ret = MReturn::New(func.alloc, p);
     exit->end(ret);
 
     exit->addPredecessorWithoutPhis(then);
--- a/js/src/jsapi-tests/testJitGVN.cpp
+++ b/js/src/jsapi-tests/testJitGVN.cpp
@@ -56,19 +56,16 @@ BEGIN_TEST(testJitGVN_FixupOSROnlyLoop)
     outerHeader->end(MTest::New(func.alloc, xBeta, merge, exit));
 
     MConstant *y = MConstant::New(func.alloc, BooleanValue(false));
     innerHeader->add(y);
     MBeta *yBeta = MBeta::New(func.alloc, y, Range::NewInt32Range(func.alloc, 0, 1));
     innerHeader->add(yBeta);
     innerHeader->end(MTest::New(func.alloc, yBeta, innerBackedge, outerBackedge));
 
-    MNop *anchor = MNop::New(func.alloc);
-    anchor->setGuard();
-    innerBackedge->add(anchor);
     innerBackedge->end(MGoto::New(func.alloc, innerHeader));
     outerBackedge->end(MGoto::New(func.alloc, outerHeader));
 
     MConstant *u = MConstant::New(func.alloc, UndefinedValue());
     exit->add(u);
     exit->end(MReturn::New(func.alloc, u));
 
     innerHeader->addPredecessorWithoutPhis(innerBackedge);
@@ -150,19 +147,16 @@ BEGIN_TEST(testJitGVN_FixupOSROnlyLoopNe
     middleHeader->end(MTest::New(func.alloc, yBeta, merge, outerBackedge));
 
     MConstant *w = MConstant::New(func.alloc, BooleanValue(false));
     innerHeader->add(w);
     MBeta *wBeta = MBeta::New(func.alloc, w, Range::NewInt32Range(func.alloc, 0, 1));
     innerHeader->add(wBeta);
     innerHeader->end(MTest::New(func.alloc, wBeta, innerBackedge, middleBackedge));
 
-    MNop *anchor = MNop::New(func.alloc);
-    anchor->setGuard();
-    innerBackedge->add(anchor);
     innerBackedge->end(MGoto::New(func.alloc, innerHeader));
     middleBackedge->end(MGoto::New(func.alloc, middleHeader));
     outerBackedge->end(MGoto::New(func.alloc, outerHeader));
 
     MConstant *u = MConstant::New(func.alloc, UndefinedValue());
     exit->add(u);
     exit->end(MReturn::New(func.alloc, u));